From: Jeremi Piotrowski <jpiotrowski@linux.microsoft.com>
To: Tom Lendacky <thomas.lendacky@amd.com>, linux-kernel@vger.kernel.org
Cc: Brijesh Singh <brijesh.singh@amd.com>,
"Kalra, Ashish" <ashish.kalra@amd.com>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH v1 5/8] crypto: cpp - Bind to psp platform device on x86
Date: Wed, 8 Feb 2023 13:48:58 +0100 [thread overview]
Message-ID: <354a02a2-7335-4600-ee38-b9a57f5381ec@linux.microsoft.com> (raw)
In-Reply-To: <272a68e1-ca89-ff30-81e3-79dfcf211615@amd.com>
On 31/01/2023 20:51, Tom Lendacky wrote:
> On 1/23/23 09:22, Jeremi Piotrowski wrote:
>> The PSP in Hyper-V VMs is exposed through the ASP ACPI table and is
>> represented as a platform_device. Allow the ccp driver to bind to it by
>> adding an id_table and initing the platform_driver also on x86. At this
>> point probe is called for the psp device but init fails due to missing
>> driver data.
>>
>> Signed-off-by: Jeremi Piotrowski <jpiotrowski@linux.microsoft.com>
>> ---
>> drivers/crypto/ccp/sp-dev.c | 8 ++++++--
>> drivers/crypto/ccp/sp-platform.c | 7 +++++++
>> 2 files changed, 13 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/crypto/ccp/sp-dev.c b/drivers/crypto/ccp/sp-dev.c
>> index 7eb3e4668286..52b8d957d0f6 100644
>> --- a/drivers/crypto/ccp/sp-dev.c
>> +++ b/drivers/crypto/ccp/sp-dev.c
>> @@ -258,7 +258,11 @@ static int __init sp_mod_init(void)
>> ret = sp_pci_init();
>> if (ret)
>> return ret;
>> -
> Please keep the blank line here.>
ok
>> + ret = sp_platform_init();
>> + if (ret) {
>> + sp_pci_exit();
>> + return ret;
>> + }
>
> Add a blank line here.
>
ok
>> #ifdef CONFIG_CRYPTO_DEV_SP_PSP
>> psp_pci_init();
>> #endif
>> @@ -286,7 +290,7 @@ static void __exit sp_mod_exit(void)
>> #ifdef CONFIG_CRYPTO_DEV_SP_PSP
>> psp_pci_exit();
>> #endif
>> -
>
> Please keep the blank line here.
>
ok
>> + sp_platform_exit(); > sp_pci_exit();
>> #endif
>> diff --git a/drivers/crypto/ccp/sp-platform.c b/drivers/crypto/ccp/sp-platform.c
>> index 7d79a8744f9a..ea8926e87981 100644
>> --- a/drivers/crypto/ccp/sp-platform.c
>> +++ b/drivers/crypto/ccp/sp-platform.c
>> @@ -56,6 +56,12 @@ static const struct of_device_id sp_of_match[] = {
>> MODULE_DEVICE_TABLE(of, sp_of_match);
>> #endif
>> +static const struct platform_device_id sp_plat_match[] = {
>
> s/plat/platform/
>
ok
> Thanks,
> Tom
>
>> + { "psp" },
>> + { },
>> +};
>> +MODULE_DEVICE_TABLE(platform, sp_plat_match);
>> +
>> static struct sp_dev_vdata *sp_get_of_version(struct platform_device *pdev)
>> {
>> #ifdef CONFIG_OF
>> @@ -212,6 +218,7 @@ static int sp_platform_resume(struct platform_device *pdev)
>> #endif
>> static struct platform_driver sp_platform_driver = {
>> + .id_table = sp_plat_match,
>> .driver = {
>> .name = "ccp",
>> #ifdef CONFIG_ACPI
next prev parent reply other threads:[~2023-02-08 12:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 15:22 [PATCH v1 0/8] Support ACPI PSP on Hyper-V Jeremi Piotrowski
2023-01-23 15:22 ` [PATCH v1 2/8] ACPI: ASPT: Add helper to parse table Jeremi Piotrowski
2023-01-23 15:22 ` [PATCH v1 5/8] crypto: cpp - Bind to psp platform device on x86 Jeremi Piotrowski
2023-01-31 19:51 ` Tom Lendacky
2023-02-08 12:48 ` Jeremi Piotrowski [this message]
2023-01-23 15:22 ` [PATCH v1 6/8] crypto: ccp - Add vdata for platform device Jeremi Piotrowski
2023-01-31 20:36 ` Tom Lendacky
2023-02-01 19:24 ` Jeremi Piotrowski
2023-02-06 19:13 ` Tom Lendacky
2023-02-08 12:45 ` Jeremi Piotrowski
2023-02-08 17:23 ` Tom Lendacky
2023-01-23 15:22 ` [PATCH v1 7/8] crypto: ccp - Skip DMA coherency check for platform psp Jeremi Piotrowski
2023-01-31 20:42 ` Tom Lendacky
2023-02-08 12:56 ` Jeremi Piotrowski
2023-01-23 15:22 ` [PATCH v1 8/8] crypto: ccp - Allow platform device to be psp master device Jeremi Piotrowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=354a02a2-7335-4600-ee38-b9a57f5381ec@linux.microsoft.com \
--to=jpiotrowski@linux.microsoft.com \
--cc=ashish.kalra@amd.com \
--cc=brijesh.singh@amd.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).