From: Stephan Mueller <smueller@chronox.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: pebolle@tiscali.nl, andreas.steffen@strongswan.org,
tytso@mit.edu, sandyinchina@gmail.com,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH v7 1/5] random: Blocking API for accessing nonblocking_pool
Date: Wed, 20 May 2015 20:49:45 +0200 [thread overview]
Message-ID: <3555912.bTyystq8tU@tachyon.chronox.de> (raw)
In-Reply-To: <20150520184535.GA15438@gondor.apana.org.au>
Am Donnerstag, 21. Mai 2015, 02:45:35 schrieb Herbert Xu:
Hi Herbert,
> On Wed, May 20, 2015 at 07:44:39PM +0200, Stephan Mueller wrote:
> > + if (unlikely(nonblocking_pool.initialized == 0)) {
> > + do {
> > + rc = wait_event_interruptible(urandom_init_wait,
> > + nonblocking_pool.initialized);
> > + } while (rc == -ERESTARTSYS);
>
> This is just a convoluted way of doing an uninterruptible sleep.
> Either make it uninterruptible or allow the function to return
> an error.
Sorry, I overlooked the availability of wait_event. I was looking for it
initially, but missed it. I will fix it right away.
--
Ciao
Stephan
next prev parent reply other threads:[~2015-05-20 18:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 17:44 [PATCH v7 0/5] Seeding DRBG with more entropy Stephan Mueller
2015-05-20 17:44 ` [PATCH v7 1/5] random: Blocking API for accessing nonblocking_pool Stephan Mueller
2015-05-20 18:45 ` Herbert Xu
2015-05-20 18:49 ` Stephan Mueller [this message]
2015-05-20 19:38 ` Stephan Mueller
2015-05-20 17:45 ` [PATCH v7 2/5] crypto: drbg - prepare for async seeding Stephan Mueller
2015-05-20 17:45 ` [PATCH v7 3/5] crypto: drbg - add async seeding operation Stephan Mueller
2015-05-20 17:46 ` [PATCH v7 4/5] crypto: drbg - use Jitter RNG to obtain seed Stephan Mueller
2015-05-20 17:46 ` [PATCH v7 5/5] crypto: add jitterentropy RNG Stephan Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3555912.bTyystq8tU@tachyon.chronox.de \
--to=smueller@chronox.de \
--cc=andreas.steffen@strongswan.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=sandyinchina@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox