Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Stephan Mueller <smueller@chronox.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: pebolle@tiscali.nl, andreas.steffen@strongswan.org,
	tytso@mit.edu, sandyinchina@gmail.com,
	linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH v5 1/5] random: Async and sync API for accessing nonblocking_pool
Date: Mon, 11 May 2015 09:30:11 +0200	[thread overview]
Message-ID: <3644541.vBsSXgpCaS@tauon> (raw)
In-Reply-To: <20150511065714.GA2598@gondor.apana.org.au>

Am Montag, 11. Mai 2015, 14:57:14 schrieb Herbert Xu:

Hi Herbert,
>
>There are two problems with this patch:
>
>1) The interface is way too complicated for a once off wait used
>only during boot.  Really there is no need for cancellations.

I will remove that in the next installment. But that means that the DRBG 
kernel module (or any other module) cannot be unloaded until the work 
completes.
>
>2) There is potential for deadlock because you schedule a work that
>then sits around until the entropy is available.  What if whatever
>is generating that entropy used the same work thread in future?
>
>So I suggest instead an interface that simply schedules a work
>when the entropy is available.

Are you suggesting to only leave get_blocking_random_bytes and have the caller 
implementing the appropriate synchronous wait or async work?

Ciao
Stephan

  reply	other threads:[~2015-05-11  7:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08  6:40 [PATCH v5 0/5] Seeding DRBG with more entropy Stephan Mueller
2015-05-08  6:41 ` [PATCH v5 1/5] random: Async and sync API for accessing nonblocking_pool Stephan Mueller
2015-05-11  6:57   ` Herbert Xu
2015-05-11  7:30     ` Stephan Mueller [this message]
2015-05-11  9:28       ` Herbert Xu
2015-05-08  6:42 ` [PATCH v5 2/5] crypto: drbg - prepare for async seeding Stephan Mueller
2015-05-08  6:42 ` [PATCH v5 3/5] crypto: drbg - add async seeding operation Stephan Mueller
2015-05-08  6:43 ` [PATCH v5 4/5] crypto: drbg - use Jitter RNG to obtain seed Stephan Mueller
2015-05-08  6:44 ` [PATCH v5 5/5] crypto: add jitterentropy RNG Stephan Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3644541.vBsSXgpCaS@tauon \
    --to=smueller@chronox.de \
    --cc=andreas.steffen@strongswan.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    --cc=sandyinchina@gmail.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox