From: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>
To: Wenjia Zhang <wenjia.zhang@oss.qualcomm.com>,
Abel Vesa <abelvesa@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 0/2] Enable ICE for UFS on Qualcomm Glymur
Date: Wed, 18 Nov 2026 13:50:32 +0530 [thread overview]
Message-ID: <36bd7e8b-8319-41ca-8d47-eebabc6f02ec@oss.qualcomm.com> (raw)
In-Reply-To: <20261118-glymur_ufs_ice-v1-0-2ffe4bb931a6@oss.qualcomm.com>
On 11/18/2026 12:30 PM, Wenjia Zhang wrote:
> This series enables the Inline Crypto Engine (ICE) for UFS storage
> on the Qualcomm Glymur platform, including the Glymur QCB board.
>
> The hardware reports ICE v4.0.3 with Hardware Key Manager (HWKM) v2.
>
> Patch 1 documents the Glymur ICE compatible string.
> Patch 2 adds the ICE node with its registers, clocks and power domain,
> and connects the UFS host controller to ICE through the qcom,ice phandle.
>
> Dependencies:
> Patch 2 requires the UFS nodes added by patch 1/3 ("arm64: dts: qcom: glymur: Add UFS nodes")
> from the Glymur UFS support series [1]. Its patch ID is recorded as a prerequisite below.
> Board-level UFS operation also requires the QCB enablement and PHY support from that series.
>
> Validation:
> - Observed ICE v4.0.3 and HWKM v2 during probe.
> - Standard-key and wrapped-key tests passed
> - checkpatch --strict --no-signoff: no errors, warnings or checks.
> - Targeted ICE DT binding validation passed.
> - Glymur QCB DTB compilation passed.
>
> Prerequisite:
> [1] https://lore.kernel.org/all/20261028-glymur_ufs_qcb_enablement-v5-0-09cda5e3bab3@oss.qualcomm.com/
>
Hi Wenjia,
Please drop the prerequisite and dependencies from the cover letter. The
UFS series is already in linux-next.
Also, I can't apply this series on top of the latest linux-next. Please
rebase and resend.
Thanks,
Gopikrishna
prev parent reply other threads:[~2026-11-18 8:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 7:00 [PATCH 0/2] Enable ICE for UFS on Qualcomm Glymur Wenjia Zhang
2026-11-18 7:00 ` [PATCH 1/2] dt-bindings: crypto: qcom,inline-crypto-engine: Add Glymur support Wenjia Zhang
2026-11-18 7:00 ` [PATCH 2/2] arm64: dts: qcom: glymur: Add ICE node for UFS inline encryption Wenjia Zhang
2026-11-18 8:20 ` Gopikrishna Garmidi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36bd7e8b-8319-41ca-8d47-eebabc6f02ec@oss.qualcomm.com \
--to=gopikrishna.garmidi@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wenjia.zhang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox