From: David Howells <dhowells@redhat.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: dhowells@redhat.com, linux-crypto@vger.kernel.org,
Blaise Boscaccy <bboscaccy@linux.microsoft.com>
Subject: Re: [PATCH 1/2] crypto: pkcs7: add ability to extract signed attributes by OID
Date: Tue, 25 Nov 2025 20:39:23 +0000 [thread overview]
Message-ID: <3954524.1764103163@warthog.procyon.org.uk> (raw)
In-Reply-To: <20251125190256.4034-2-James.Bottomley@HansenPartnership.com>
James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> +/**
> + * pkcs7_get_authattr - get authenticated attribute by OID
> + *
> + * @pkcs7: The preparsed PKCS#7 message
There shouldn't be a gap between those.
> + /*
> + * Note: authattrs is missing the initial tag for
> + * digesting reasons. Step one back in the stream to
> + * point to the initial tag for fully formed ASN.1
> + */
That will probably have to change to support ML-DSA.
David
next prev parent reply other threads:[~2025-11-25 20:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 19:02 [PATCH 0/2] pkcs7: better handling of signed attributes James Bottomley
2025-11-25 19:02 ` [PATCH 1/2] crypto: pkcs7: add ability to extract signed attributes by OID James Bottomley
2025-11-25 20:39 ` David Howells [this message]
2025-11-25 22:18 ` James Bottomley
2025-11-25 19:02 ` [PATCH 2/2] crypto: pkcs7: add tests for pkcs7_get_authattr James Bottomley
2025-11-25 20:41 ` David Howells
2025-11-26 17:45 ` [PATCH 0/2] pkcs7: better handling of signed attributes James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3954524.1764103163@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bboscaccy@linux.microsoft.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox