From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 425341DE2B4; Sat, 10 May 2025 09:38:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746869901; cv=none; b=LfsmdHwg3E+nSnUSs5bsXNsy1n5/fTJzozQpTOleSmiJSoXKyrPv3/Jjs9asvsa0NRaTHODNuRS08j+qw/+ldt1G4Cs643e53Xr36PiZPgvmHBcPA63U0jaUXFhMZPphq4RR+lVhtJ1Fbwvt8QspWKaV5aaMLK7P/5D9+x8ojsU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746869901; c=relaxed/simple; bh=0mTlCEWkW6rkQPOGq6Wkvk0qBns1LaA++h6ShXw6fho=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=SxWrVVnXtKY/p911oWWPV4HQGUh+Le7m6KgGS3f8YScJXdhmuqmCF7IbLD4BgEc3TLA1X8iX81cdADeL6U7NfBV8rhS/yCcYGxjaEJ98L60EwKhkdLUCT47QenPyQiZ1r5v/u2LLmZ2fKBEELiRiV8Ds5GkCcfrX+aA6AxiJr5g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I/l4cX/+; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I/l4cX/+" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-3a1d8c0966fso1461603f8f.1; Sat, 10 May 2025 02:38:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746869897; x=1747474697; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Brc+ZiTm9hUXSm8GgCWOjwKSMPotzD18vsery3NQJm8=; b=I/l4cX/+QwC9nLsNARE3rgQGSjcwS2lJqEFSEfNTxb5vXqfGfinJNnJUjP+I9adorb AWwKmr8MVORh6vRYTZXY6arjZk2WDGnxF0eHft8wiXDYvnfkqLKVrbGfuHYZmqqXxAB9 QVA+TaniMFGVGbDGTQLCLrfoz7284mzm3f58lAFF8qA+ZZNIEI2G6gIhsv0m9rF7wMGY jlibxnFuVzvmvKH6zIgn+V3uFFbbOsmqIeWXAlhX5NYYf+hWzpd1hg5vEMqF/BFbZfsH 0B/62DIsgNbnqb3R0DzTyFqKrKgYl5vnKWZ66sjpyGJShxNXML/rhqxA0a6Svwwe3sE0 2wHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746869897; x=1747474697; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Brc+ZiTm9hUXSm8GgCWOjwKSMPotzD18vsery3NQJm8=; b=HZ8y6gd9D7YBen5uEPin+WPYbMbOWZSovlv6KA5FjqwhYRkAbrtPHGdGDlI+2/Y+6N Dcqof9MMWWsTM0kFuAxKHKL4nGPJ83p0PxJkgDgT9q2VaaensjcL/4Ek+kQTuiNWFc0e TjDU6wC1YNlSmp64vH3f9YOma/rQvc1XiIy5QZFS+5eOb01rOx4zm0cAJFZ99uvdLav2 W5c28FNyTuwPcInn4UQHD+ZHBco5wGyw/BN/G8D1t15QF4iuBNvCspIFAMtWVNXycuhh Vhrd+OFATKXekqwpPPPs85Lo6TMbHdjraQA5YaklxLzpIYkn3KwiDAoAlNaD5ET6Gvol P3XA== X-Forwarded-Encrypted: i=1; AJvYcCU12/IkSEu+HKbJUnmfSGcwogzc5Fbvh9DjfEpU5ciJBqa1rdYhTUCn0IE6aPor3kpimk6AeBueSteyDYI=@vger.kernel.org, AJvYcCWCdBvbMf5H6qUwYRh4Kgdfbm9VHgkBV8XpCNZGtmRwAlN/8FkpJPdq57paP4ElMYk3q9ud7V9n9afQuzt7@vger.kernel.org X-Gm-Message-State: AOJu0YySoWaUxvgsx6jO+nDEUUcm5n21sPZtOT4iRDb7njTM+hjpc491 DbBvg3iwDVqe3SDwK7p1xReA77nN6A2r51eoBIy4jVaJ8KUT6WTo X-Gm-Gg: ASbGncu1hDjaEw+r8UuKjRV2liZ9GPpE02hshIUeQskQv9mnKdeJmwqCptxB6+FOSVk MK3BkPqMWWQKsehfmEifknHNVfgzd7mrLE+F5wWd+YZImpW3mw9XqdWc2/MYFjsQIJGigRYa3ab jqwylqRjdHC2ANOKySaRhQRu4eHKRF3rkGLz389inQ8u1lz+nGrGJP01If6admeEF0fd8xUSFo7 46l41PdFtBsHz8CnN1+9wz8SY8coKZRTbf69BYA/cpkjPnthsrm315It9RUCVPjF6FMll8N/e4F fLSx9v0BNvV3lNoX7mv4MP8PCO6YwnsM4NomzAk2/No3+6HYh3z9BXATIovqpckxT8PHDLmo89q li0PbbhlPK7fPwyAhqP7w7A== X-Google-Smtp-Source: AGHT+IFbdGYVIQ49iY5bbmzcUxZMtkwMLdtF45nk6ZTl6i0nDudvhlHAg2cQZJagCGG2wfh9qIm1OA== X-Received: by 2002:a5d:5885:0:b0:38d:dc03:a3d6 with SMTP id ffacd0b85a97d-3a0b98fcdb9mr9604832f8f.4.1746869897251; Sat, 10 May 2025 02:38:17 -0700 (PDT) Received: from ?IPv6:2a02:168:6806:0:dea1:3038:3d90:d2ab? ([2a02:168:6806:0:dea1:3038:3d90:d2ab]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a1f58ec98dsm5819768f8f.25.2025.05.10.02.38.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 May 2025 02:38:16 -0700 (PDT) Message-ID: <41680c5d41ed568e8c65451843e3ff212fd340c4.camel@gmail.com> Subject: Re: [v3 PATCH] crypto: marvell/cesa - Do not chain submitted requests From: Klaus Kudielka To: Herbert Xu Cc: Corentin Labbe , regressions@lists.linux.dev, linux-kernel@vger.kernel.org, Linux Crypto Mailing List , Boris Brezillon , EBALARD Arnaud , Romain Perier Date: Sat, 10 May 2025 11:38:16 +0200 In-Reply-To: References: <15fadc356b73a1e8e24183f284b5c0a44a53e679.camel@gmail.com> <5db212655dc98945fa3f529925821879a03ff554.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.1-1 Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Sat, 2025-05-10 at 17:05 +0800, Herbert Xu wrote: > On Sat, May 10, 2025 at 10:32:53AM +0200, Klaus Kudielka wrote: > >=20 > > So, I am back at the hardware (armada-385-turris-omnia), and gave this = patch a try. > > CONFIG_CRYPTO_DEV_MARVELL_CESA=3Dm > >=20 > > Upon modprobe marvell-cesa, I get the following results. >=20 > Thanks, could you please try this patch which goes on top of the > previous v3 patch to disable chaining completely? >=20 > Thanks, Patch applied on top. On the first attempt all self-tests passed, but on the second and third unf= ortunately not. [ 16.841981] marvell-cesa f1090000.crypto: CESA device successfully regis= tered [ 16.912258] alg: ahash: mv-sha256 test failed (wrong result) on test vec= tor 2, cfg=3D"import/export" [ 16.917574] alg: ahash: mv-md5 test failed (wrong result) on test vector= 3, cfg=3D"init+update+final misaligned buffer" [ 16.921323] alg: self-tests for sha256 using mv-sha256 failed (rc=3D-22) [ 16.931961] ------------[ cut here ]------------ [ 16.931966] WARNING: CPU: 1 PID: 388 at crypto/testmgr.c:5871 alg_test+0= x5f0/0x614 [ 16.931982] alg: self-tests for sha256 using mv-sha256 failed (rc=3D-22) [ 16.931985] Modules linked in: [ 16.931984] alg: self-tests for md5 using mv-md5 failed (rc=3D-22) [ 16.931989] ------------[ cut here ]------------ [ 16.931989] marvell_cesa libdes libaes [ 16.931993] WARNING: CPU: 0 PID: 386 at crypto/testmgr.c:5871 alg_test+0= x5f0/0x614 [ 16.932001] CPU: 1 UID: 0 PID: 388 Comm: cryptomgr_test Not tainted 6.15= .0-rc5+ #5 NONE=20 [ 16.932004] alg: self-tests for md5 using mv-md5 failed (rc=3D-22) [ 16.932007] Modules linked in: [ 16.932009] Hardware name: Marvell Armada 380/385 (Device Tree) [ 16.932012] marvell_cesa [ 16.932013] Call trace:=20 [ 16.932015] libdes libaes [ 16.932018] unwind_backtrace from show_stack+0x10/0x14 [ 16.932033] show_stack from dump_stack_lvl+0x50/0x64 [ 16.932042] dump_stack_lvl from __warn+0x7c/0xd4 [ 16.932052] __warn from warn_slowpath_fmt+0x110/0x16c [ 16.932063] warn_slowpath_fmt from alg_test+0x5f0/0x614 [ 16.932073] alg_test from cryptomgr_test+0x18/0x38 [ 16.932080] cryptomgr_test from kthread+0xe8/0x204 [ 16.932090] kthread from ret_from_fork+0x14/0x28 [ 16.932097] Exception stack(0xf0aadfb0 to 0xf0aadff8) [ 16.932102] dfa0: 00000000 00000000 = 00000000 00000000 [ 16.932107] dfc0: 00000000 00000000 00000000 00000000 00000000 00000000 = 00000000 00000000 [ 16.932112] dfe0: 00000000 00000000 00000000 00000000 00000013 00000000 [ 16.932115] ---[ end trace 0000000000000000 ]--- [ 16.932115] CPU: 0 UID: 0 PID: 386 Comm: cryptomgr_test Not tainted 6.15= .0-rc5+ #5 NONE=20 [ 16.932122] Hardware name: Marvell Armada 380/385 (Device Tree) [ 16.932125] Call trace:=20 [ 16.932127] unwind_backtrace from show_stack+0x10/0x14 [ 16.932139] show_stack from dump_stack_lvl+0x50/0x64 [ 16.932148] dump_stack_lvl from __warn+0x7c/0xd4 [ 16.932157] __warn from warn_slowpath_fmt+0x110/0x16c [ 16.932168] warn_slowpath_fmt from alg_test+0x5f0/0x614 [ 16.932178] alg_test from cryptomgr_test+0x18/0x38 [ 16.932185] cryptomgr_test from kthread+0xe8/0x204 [ 16.932193] kthread from ret_from_fork+0x14/0x28 [ 16.932200] Exception stack(0xf0aa1fb0 to 0xf0aa1ff8) [ 16.932205] 1fa0: 00000000 00000000 = 00000000 00000000 [ 16.932210] 1fc0: 00000000 00000000 00000000 00000000 00000000 00000000 = 00000000 00000000 [ 16.932214] 1fe0: 00000000 00000000 00000000 00000000 00000013 00000000 [ 16.932217] ---[ end trace 0000000000000000 ]--- [ 16.932990] alg: ahash: mv-hmac-md5 setkey failed on test vector 0; expe= cted_error=3D0, actual_error=3D-80, flags=3D0x1 [ 16.943346] alg: self-tests for hmac(md5) using mv-hmac-md5 failed (rc= =3D-80) [ 16.943353] ------------[ cut here ]------------ [ 16.943357] WARNING: CPU: 0 PID: 391 at crypto/testmgr.c:5871 alg_test+0= x5f0/0x614 [ 16.943370] alg: self-tests for hmac(md5) using mv-hmac-md5 failed (rc= =3D-80) [ 16.943374] Modules linked in: marvell_cesa libdes libaes [ 16.943408] CPU: 0 UID: 0 PID: 391 Comm: cryptomgr_test Tainted: G = W 6.15.0-rc5+ #5 NONE=20 [ 16.943418] Tainted: [W]=3DWARN [ 16.943420] Hardware name: Marvell Armada 380/385 (Device Tree) [ 16.943423] Call trace:=20 [ 16.943428] unwind_backtrace from show_stack+0x10/0x14 [ 16.943445] show_stack from dump_stack_lvl+0x50/0x64 [ 16.943455] dump_stack_lvl from __warn+0x7c/0xd4 [ 16.943465] __warn from warn_slowpath_fmt+0x110/0x16c [ 16.943476] warn_slowpath_fmt from alg_test+0x5f0/0x614 [ 16.943487] alg_test from cryptomgr_test+0x18/0x38 [ 16.943495] cryptomgr_test from kthread+0xe8/0x204 [ 16.943504] kthread from ret_from_fork+0x14/0x28 [ 16.943512] Exception stack(0xf0ab9fb0 to 0xf0ab9ff8) [ 16.943517] 9fa0: 00000000 00000000 = 00000000 00000000 [ 16.943522] 9fc0: 00000000 00000000 00000000 00000000 00000000 00000000 = 00000000 00000000 [ 16.943527] 9fe0: 00000000 00000000 00000000 00000000 00000013 00000000 [ 16.943530] ---[ end trace 0000000000000000 ]--- [ 16.943600] alg: ahash: mv-hmac-sha256 setkey failed on test vector 0; e= xpected_error=3D0, actual_error=3D-80, flags=3D0x1 [ 16.954188] alg: self-tests for hmac(sha256) using mv-hmac-sha256 failed= (rc=3D-80) [ 16.954195] ------------[ cut here ]------------ [ 16.954200] WARNING: CPU: 0 PID: 394 at crypto/testmgr.c:5871 alg_test+0= x5f0/0x614 [ 16.954211] alg: self-tests for hmac(sha256) using mv-hmac-sha256 failed= (rc=3D-80) [ 16.954215] Modules linked in: marvell_cesa libdes libaes [ 16.954229] CPU: 0 UID: 0 PID: 394 Comm: cryptomgr_test Tainted: G = W 6.15.0-rc5+ #5 NONE=20 [ 16.954236] Tainted: [W]=3DWARN [ 16.954238] Hardware name: Marvell Armada 380/385 (Device Tree) [ 16.954241] Call trace:=20 [ 16.954244] unwind_backtrace from show_stack+0x10/0x14 [ 16.954257] show_stack from dump_stack_lvl+0x50/0x64 [ 16.954266] dump_stack_lvl from __warn+0x7c/0xd4 [ 16.954275] __warn from warn_slowpath_fmt+0x110/0x16c [ 16.954286] warn_slowpath_fmt from alg_test+0x5f0/0x614 [ 16.954296] alg_test from cryptomgr_test+0x18/0x38 [ 16.954304] cryptomgr_test from kthread+0xe8/0x204 [ 16.954312] kthread from ret_from_fork+0x14/0x28 [ 16.954320] Exception stack(0xf0ac5fb0 to 0xf0ac5ff8) [ 16.954324] 5fa0: 00000000 00000000 = 00000000 00000000 [ 16.954329] 5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 = 00000000 00000000 [ 16.954333] 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000 [ 16.954336] ---[ end trace 0000000000000000 ]---