Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Alexandre Torgue <alexandre.torgue@st.com>
To: "Alexander A. Klimov" <grandmaster@al2klimov.de>,
	<linux@armlinux.org.uk>, <mcoquelin.stm32@gmail.com>,
	<herbert@gondor.apana.org.au>, <davem@davemloft.net>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-stm32@st-md-mailman.stormreply.com>,
	<linux-kernel@vger.kernel.org>, <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH for v5.9] ARM: STM32: Replace HTTP links with HTTPS ones
Date: Tue, 21 Jul 2020 10:49:17 +0200	[thread overview]
Message-ID: <43c11c7a-269e-cc41-6934-0d2e0dec3226@st.com> (raw)
In-Reply-To: <20200719094948.57487-1-grandmaster@al2klimov.de>

Hi Alexander

On 7/19/20 11:49 AM, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
> 
> Deterministic algorithm:
> For each file:
>    If not .svg:
>      For each line:
>        If doesn't contain `\bxmlns\b`:
>          For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> 	  If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
>              If both the HTTP and HTTPS versions
>              return 200 OK and serve the same content:
>                Replace HTTP with HTTPS.
> 
> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>

This patch touch 2 different subsystems. Can you please split it ?

Regards
Alex


> ---
>   Continuing my work started at 93431e0607e5.
>   See also: git log --oneline '--author=Alexander A. Klimov <grandmaster@al2klimov.de>' v5.7..master
>   (Actually letting a shell for loop submit all this stuff for me.)
> 
>   If there are any URLs to be removed completely
>   or at least not (just) HTTPSified:
>   Just clearly say so and I'll *undo my change*.
>   See also: https://lkml.org/lkml/2020/6/27/64
> 
>   If there are any valid, but yet not changed URLs:
>   See: https://lkml.org/lkml/2020/6/26/837
> 
>   If you apply the patch, please let me know.
> 
>   Sorry again to all maintainers who complained about subject lines.
>   Now I realized that you want an actually perfect prefixes,
>   not just subsystem ones.
>   I tried my best...
>   And yes, *I could* (at least half-)automate it.
>   Impossible is nothing! :)
> 
> 
>   arch/arm/mach-stm32/Makefile.boot | 2 +-
>   crypto/testmgr.h                  | 6 +++---
>   2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/mach-stm32/Makefile.boot b/arch/arm/mach-stm32/Makefile.boot
> index cec195d4fcba..5dde7328a7a9 100644
> --- a/arch/arm/mach-stm32/Makefile.boot
> +++ b/arch/arm/mach-stm32/Makefile.boot
> @@ -1,4 +1,4 @@
>   # SPDX-License-Identifier: GPL-2.0-only
>   # Empty file waiting for deletion once Makefile.boot isn't needed any more.
>   # Patch waits for application at
> -# http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=7889/1 .
> +# https://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=7889/1 .
> diff --git a/crypto/testmgr.h b/crypto/testmgr.h
> index d29983908c38..cdcf0d2fe40d 100644
> --- a/crypto/testmgr.h
> +++ b/crypto/testmgr.h
> @@ -16231,7 +16231,7 @@ static const struct cipher_testvec aes_lrw_tv_template[] = {
>   			  "\xe9\x5d\x48\x92\x54\x63\x4e\xb8",
>   		.len	= 48,
>   	}, {
> -/* http://www.mail-archive.com/stds-p1619@listserv.ieee.org/msg00173.html */
> +/* https://www.mail-archive.com/stds-p1619@listserv.ieee.org/msg00173.html */
>   		.key    = "\xf8\xd4\x76\xff\xd6\x46\xee\x6c"
>   			  "\x23\x84\xcb\x1c\x77\xd6\x19\x5d"
>   			  "\xfe\xf1\xa9\xf3\x7b\xbc\x8d\x21"
> @@ -21096,7 +21096,7 @@ static const struct aead_testvec aegis128_tv_template[] = {
>   
>   /*
>    * All key wrapping test vectors taken from
> - * http://csrc.nist.gov/groups/STM/cavp/documents/mac/kwtestvectors.zip
> + * https://csrc.nist.gov/groups/STM/cavp/documents/mac/kwtestvectors.zip
>    *
>    * Note: as documented in keywrap.c, the ivout for encryption is the first
>    * semiblock of the ciphertext from the test vector. For decryption, iv is
> @@ -22825,7 +22825,7 @@ static const struct cipher_testvec xeta_tv_template[] = {
>    * FCrypt test vectors
>    */
>   static const struct cipher_testvec fcrypt_pcbc_tv_template[] = {
> -	{ /* http://www.openafs.org/pipermail/openafs-devel/2000-December/005320.html */
> +	{ /* https://www.openafs.org/pipermail/openafs-devel/2000-December/005320.html */
>   		.key	= "\x00\x00\x00\x00\x00\x00\x00\x00",
>   		.klen	= 8,
>   		.iv	= "\x00\x00\x00\x00\x00\x00\x00\x00",
> 

  reply	other threads:[~2020-07-21  8:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-19  9:49 [PATCH for v5.9] ARM: STM32: Replace HTTP links with HTTPS ones Alexander A. Klimov
2020-07-21  8:49 ` Alexandre Torgue [this message]
2020-07-21 17:49   ` Alexander A. Klimov
2020-07-22  7:06     ` Alexandre Torgue
2020-07-22  7:11       ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43c11c7a-269e-cc41-6934-0d2e0dec3226@st.com \
    --to=alexandre.torgue@st.com \
    --cc=davem@davemloft.net \
    --cc=grandmaster@al2klimov.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux@armlinux.org.uk \
    --cc=mcoquelin.stm32@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox