From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B0883932D1 for ; Wed, 20 May 2026 07:50:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779263413; cv=none; b=T6jvFB2w/c7HEZe8nlNZtoupYSp6WZYmt15ASzS7X5J6KFwqzOwPPhnlWKLxQdnzOsHKtaAJZDgDOx8g3akCY2imy3t+EVeyHC2SufE/AGO2h9Ng9Y2kdnRvJuVMBZO5mE7tOGLzDa/+cfwmBWcNIreLdoE6ObX0wD7wdlikzTw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779263413; c=relaxed/simple; bh=AW50yD+8G3hktr8ExmRUEhx7mbn9PGG4W01JvarkTeM=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=aQVcdyeYGv20ZTtIbnhOMlt8T+73Ql46wS5Ex4SbOf3AOXVVf+NkSBiR+z2ePoOMxdD84T9RD9uizb4IHXx3jW4I67FqEbHsr6xFEhf6YvjTf2KM/sPj3wRwJAZExrZmb/tf05+ddsgkNyzf5ZOriujzZhaoZB9tttWqiPS+G5Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SD/qTkLN; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SD/qTkLN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9859D1F00894; Wed, 20 May 2026 07:50:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779263412; bh=0wHdicrLTHaXzXB7dJnKcgscr1vx1F9p95EeRolG7Cg=; h=Date:From:To:Cc:In-Reply-To:References:Subject; b=SD/qTkLNCYuv77dgJY3q9IM14jxb9e3Iaatubww+KyIOt9IlgKBIY5cCzB3Y6B9me FywLHY2w6vv5+/rqYtfMzCIJ7HWzma4LmWS6ejIDs4KoUuXyps6Lti/Dl5pLtxVCuz 1cDf5RqANIb36Tfl6PkeKT5IkSSbeNzTuCi7Ggp4LANY2ZScRD9FDiiXoqPPBr8tYa 3bNUawpVFSx2Ls7a8LqGn5o7Y34CodDordu3cHUpBuvFaGve6GWWri5S5FokalHcft kSgUvtY/jGcrWWppRJurNCTB7QC6rPIhi54tK2ZK2H91kR8RtO75PJhcW6KmsGPx/1 K6A0ZkB2Eo1Ww== Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfauth.phl.internal (Postfix) with ESMTP id BB917F4007D; Wed, 20 May 2026 03:50:10 -0400 (EDT) Received: from phl-imap-05 ([10.202.2.95]) by phl-compute-01.internal (MEProxy); Wed, 20 May 2026 03:50:10 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgddugeegtdejucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepofggfffhvfevkfgjfhfutgfgsehtqhertdertdejnecuhfhrohhmpedftehrugcu uehivghshhgvuhhvvghlfdcuoegrrhgusgeskhgvrhhnvghlrdhorhhgqeenucggtffrrg htthgvrhhnpeeuteeiudeigeekjedvheduieehteetgfdtuefghfejgffhfedtleehvdeh fffhvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhguodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdduieejtdehtddtjeel qdeffedvudeigeduhedqrghruggspeepkhgvrhhnvghlrdhorhhgseifohhrkhhofhgrrh gurdgtohhmpdhnsggprhgtphhtthhopedutddpmhhouggvpehsmhhtphhouhhtpdhrtghp thhtohepuhdrkhhlvghinhgvqdhkohgvnhhighessggrhihlihgsrhgvrdgtohhmpdhrtg hpthhtoheprghlvgigrghnughrvgdrsggvlhhlohhnihessghoohhtlhhinhdrtghomhdp rhgtphhtthhopegurghvvghmsegurghvvghmlhhofhhtrdhnvghtpdhrtghpthhtohephh gvrhgsvghrthesghhonhguohhrrdgrphgrnhgrrdhorhhgrdgruhdprhgtphhtthhopeht hhhorhhsthgvnhdrsghluhhmsehlihhnuhigrdguvghvpdhrtghpthhtoheplhhinhhugi dqrghrmhdqkhgvrhhnvghlsehlihhsthhsrdhinhhfrhgruggvrggurdhorhhgpdhrtghp thhtohepnhhitgholhgrshdrfhgvrhhrvgesmhhitghrohgthhhiphdrtghomhdprhgtph htthhopegtlhgruhguihhurdgsvgiinhgvrgesthhugihonhdruggvvhdprhgtphhtthho pehlihhnuhigqdgtrhihphhtohesvhhgvghrrdhkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: ice86485a:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 9683F182007A; Wed, 20 May 2026 03:50:10 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Wed, 20 May 2026 09:49:49 +0200 From: "Ard Biesheuvel" To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= , "Thorsten Blum" , "Herbert Xu" , "David S. Miller" , "Nicolas Ferre" , "Alexandre Belloni" , "Claudiu Beznea" Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Message-Id: <46130020-eaa5-44ad-9c6d-62ccb30c19d9@app.fastmail.com> In-Reply-To: References: Subject: Re: [PATCH v2 1/3] crypto: atmel-sha204a - Drop of_device_id data Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed, 20 May 2026, at 09:01, Uwe Kleine-K=C3=B6nig (The Capable Hub) w= rote: > The driver binds to i2c devices only and thus in the absence of an > assignment for .data in the of_device_id array i2c_get_match_data() > falls back to .driver_data from the i2c_device_id array. So only provi= de > &atsha204_quality once to reduce duplication. > > Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) > --- > drivers/crypto/atmel-sha204a.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha= 204a.c > index 6e6ac4770416..f17e1f6af1a3 100644 > --- a/drivers/crypto/atmel-sha204a.c > +++ b/drivers/crypto/atmel-sha204a.c > @@ -208,8 +208,8 @@ static void atmel_sha204a_remove(struct i2c_client= *client) > } >=20 > static const struct of_device_id atmel_sha204a_dt_ids[] =3D { > - { .compatible =3D "atmel,atsha204", .data =3D &atsha204_quality }, > - { .compatible =3D "atmel,atsha204a", }, > + { .compatible =3D "atmel,atsha204" }, > + { .compatible =3D "atmel,atsha204a" }, > { } > }; > MODULE_DEVICE_TABLE(of, atmel_sha204a_dt_ids); Just trying to figure out how this is supposed to work: i2c_get_match_data() data =3D device_get_match_data(&client->dev); ... returns NULL ... if (!data) { match =3D i2c_match_id(driver->id_table, client); ... compares client->name with { "atsha204", "atsha204a" } So we will be relying on client->name having been set to either=20 "atsha204" or "atsha204a" on the DT probe path before i2c_match_data() is called, but I am struggling to see where that might happen.