From: Milan Broz <mbroz@redhat.com>
To: device-mapper development <dm-devel@redhat.com>
Cc: Christophe Saout <christophe@saout.de>,
Alasdair G Kergon <agk@redhat.com>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH 1/3] [DM] dm-crypt: Move post-processing into its own queue
Date: Wed, 25 Jul 2007 11:45:22 +0200 [thread overview]
Message-ID: <46A71BB2.5070806@redhat.com> (raw)
In-Reply-To: <E1I8SWH-0001lg-00@gondolin.me.apana.org.au>
Hi Herbert,
Herbert Xu wrote:
> [DM] dm-crypt: Move post-processing into its own queue
>
>
> + _kcryptd_io_workqueue = create_workqueue("kcryptd-io");
Adding another qlobal per-cpu queue can lead to wasteful creating
of too many kernel threads in system (system with many cores etc.)
I have similar patches in my tree where the queues are created
per crypt device (so every crypt device create two single-threaded
queues).
(And I am thinking about future support of barriers - it can be
really complicated with global workqueue too.)
> @@ -1097,6 +1129,7 @@ static void __exit dm_crypt_exit(void)
> if (r < 0)
> DMERR("unregister failed %d", r);
>
> + destroy_workqueue(_kcryptd_io_workqueue);
also flush_workqueue(_kcryptd_io_workqueue) in crypt_dtr should be there.
Milan
--
mbroz@redhat.com
next prev parent reply other threads:[~2007-07-25 9:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-11 3:03 [0/3] [DM] dm-crypt: Add async crypto support Herbert Xu
2007-07-11 3:05 ` [PATCH 1/3] [DM] dm-crypt: Move post-processing into its own queue Herbert Xu
2007-07-25 9:45 ` Milan Broz [this message]
2007-07-11 3:05 ` [PATCH 2/3] [DM] dm-crypt: Add async infrastructure Herbert Xu
2007-07-11 3:05 ` [PATCH 3/3] [DM] dm-crypt: Use crypto ablkcipher interface Herbert Xu
2007-07-11 7:45 ` [0/3] [DM] dm-crypt: Add async crypto support Andreas Jellinghaus
2007-07-25 9:23 ` Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2007-04-16 10:58 [0/3] [DM] dm-crypt: Add async blkcipher support Herbert Xu
2007-04-16 10:59 ` [PATCH 1/3] [DM] dm-crypt: Move post-processing into its own queue Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A71BB2.5070806@redhat.com \
--to=mbroz@redhat.com \
--cc=agk@redhat.com \
--cc=christophe@saout.de \
--cc=dm-devel@redhat.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox