linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] fix alignment problem in XTS and LRW blockmode
@ 2008-03-02 13:51 Sebastian Siewior
  2008-03-02 11:09 ` [PATCH] [crypto] XTS: use proper alignment Sebastian Siewior
  0 siblings, 1 reply; 22+ messages in thread
From: Sebastian Siewior @ 2008-03-02 13:51 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-crypto

Hello Herbert,

this fixes the bug reported by Stefan Hellermann which breaks his
padlock-aes.

Sebastian

^ permalink raw reply	[flat|nested] 22+ messages in thread
* [RFC] padlock aes, unification of setkey()
@ 2008-02-24 11:01 Sebastian Siewior
  2008-02-24 11:54 ` Stefan Hellermann
  0 siblings, 1 reply; 22+ messages in thread
From: Sebastian Siewior @ 2008-02-24 11:01 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-crypto

>From Sebastian Siewior <sebastian@breakpoint.cc> # This line is ignored.
Subject: [RFC] padlock aes, unification of setkey()

Hello Herbert,

I sit on those two since November. Back then Michal dropped me an email
and told me that he will test it and get back to me. This didn't happen
so far.
The binary format of the key was the same, the last time I checked, so
the second patch could really work :)

One thing I'm concerned about is the stack utilization. The initial
version had a structure with 256 bytes on the stack. Mine has a bigger
structure with 484 bytes. I'm not sure if it is better to dynamically
allocate it, move it to the private key structure or pad the generic
aes structure in order to enforce the required alignment.

Sebastian

^ permalink raw reply	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2008-03-06 10:57 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-02 13:51 [PATCH] fix alignment problem in XTS and LRW blockmode Sebastian Siewior
2008-03-02 11:09 ` [PATCH] [crypto] XTS: use proper alignment Sebastian Siewior
2008-03-02 13:35   ` [PATCH] [PATCH] [crypto] LRW: " Sebastian Siewior
2008-03-02 14:01     ` Stefan Hellermann
2008-03-02 16:23       ` Herbert Xu
2008-03-05 11:17     ` Herbert Xu
2008-03-05 11:16   ` [PATCH] [crypto] XTS: " Herbert Xu
2008-03-05 11:46     ` Sebastian Siewior
2008-03-05 11:52       ` Herbert Xu
2008-03-05 12:01         ` Sebastian Siewior
2008-03-05 14:02           ` Stefan Hellermann
2008-03-05 16:37             ` Sebastian Siewior
2008-03-05 22:17               ` [PATCH] [crypto] XTS: use proper alignment v2 Sebastian Siewior
2008-03-05 22:48                 ` Stefan Hellermann
2008-03-06  8:52                   ` Sebastian Siewior
2008-03-06 10:53                     ` Stefan Hellermann
2008-03-06 10:57                   ` Herbert Xu
  -- strict thread matches above, loose matches on Subject: below --
2008-02-24 11:01 [RFC] padlock aes, unification of setkey() Sebastian Siewior
2008-02-24 11:54 ` Stefan Hellermann
2008-02-24 12:51   ` Sebastian Siewior
2008-02-24 20:07     ` Via Padlock Bug with LRW/XTS Stefan Hellermann
2008-03-02 11:20       ` [PATCH] [crypto] XTS: use proper alignment Sebastian Siewior
2008-03-02 12:04         ` Stefan Hellermann
2008-03-02 13:22           ` Sebastian Siewior
2008-03-02 13:49             ` Stefan Hellermann
2008-03-02 14:04               ` Stefan Hellermann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).