Re: tcrypt: hmac test with keys > blocksize fail

["Adrian-Ken Rüegsegger" <rueegsegger@swiss-it.ch>]

Sebastian Siewior wrote:
> * Adrian-Ken R?egsegger | 2008-05-03 02:10:34 [+0200]:
> 
>> Hi,
> Hi Adrian-Ken,

Hello Sebastian,

>> using the cryptodev-2.6 tree I noticed that the hmac tests that have
>> keys larger than blocksize for md5 and the various sha algorithms all
>> fail (tcrypt mode=10[0-5]). The other tests seem to pass just fine.
>>
>> The issue seems to have come from commit
>> de224c309b5631bdaae3fcd6880cfb93b52f5a53.
> Is this a bisect result?

No, this was a guess of mine, since I tested the two revisions just
prior and after the three tcrypt-commits from you. I did a full bisect
and the actual guilty commit is:

[562954d5e01d08154cf15c7e12e6e9ec803f50f7] [CRYPTO] tcrypt: Change the
usage of the test vectors

>> I have tested 48c8949ea8460216783dd33640121187b9531b60 which does not
>> contain this bug.  It's just before the various tcrypt-changes from
>> Sebastian Siewior.
> I tested it with tcrypt mode=0 what covers 100-105 but it may slip
> through. I will look into this later.

As I mentioned, it's only the hmac tests with keys larger than blocksize
that fail.
Additionaly I just saw, that ecb(des) encryption test nr 5 passes but it
seems that the setkey operation fails with:

setkey() failed flags=100100

-Adrian