Re: [RFC PATCH] [XFRM] xfrm_algo: correct usage of RIPEMD-160

[Adrian-Ken Rueegsegger <rueegsegger@swiss-it.ch>]

Sebastian Siewior wrote:
> * Adrian-Ken Rueegsegger | 2008-06-01 19:16:18 [+0200]:
> 
>> This patch fixes the usage of RIPEMD-160 in xfrm_algo which in turn
>> allows hmac(rmd160) to be used as authentication mechanism in IPsec
>> ESP and AH (see RFC 2857).
>>
>> Signed-off-by: Adrian-Ken Rueegsegger <rueegsegger@swiss-it.ch>
>> ---
>> net/xfrm/xfrm_algo.c |    4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/net/xfrm/xfrm_algo.c b/net/xfrm/xfrm_algo.c
>> index ac765dd..23a2cc0 100644
>> --- a/net/xfrm/xfrm_algo.c
>> +++ b/net/xfrm/xfrm_algo.c
>> @@ -200,8 +200,8 @@ static struct xfrm_algo_desc aalg_list[] = {
>> 	}
>> },
>> {
>> -	.name = "hmac(ripemd160)",
>> -	.compat = "ripemd160",
>> +	.name = "hmac(rmd160)",
>> +	.compat = "rmd160",
> 
> On the other hand you could rename the algorithm itself couldn't you?

Yes, that would be the other way to do it. Is there a preference or specific reason
for renaming the hash algorithm than changing the reference to the algorithm?

Thanks,
Adrian

> 
> Sebastian