From: Dan Carpenter <dan.carpenter@linaro.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: "Marek Behún" <kabel@kernel.org>,
Jonathan.Cameron@huawei.com, Laurent.pinchart@ideasonboard.com,
airlied@gmail.com, andrzej.hajda@intel.com, arm@kernel.org,
arnd@arndb.de, bamv2005@gmail.com, brgl@bgdev.pl,
daniel@ffwll.ch, davem@davemloft.net, dianders@chromium.org,
dri-devel@lists.freedesktop.org, eajames@linux.ibm.com,
gaurav.jain@nxp.com, gregory.clement@bootlin.com,
hdegoede@redhat.com, herbert@gondor.apana.org.au,
horia.geanta@nxp.com, james.clark@arm.com, james@equiv.tech,
jdelvare@suse.com, jernej.skrabec@gmail.com, jonas@kwiboo.se,
linus.walleij@linaro.org, linux-crypto@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org, linux@roeck-us.net,
maarten.lankhorst@linux.intel.com, mazziesaccount@gmail.com,
mripard@kernel.org, naresh.solanki@9elements.com,
neil.armstrong@linaro.org, pankaj.gupta@nxp.com,
patrick.rudolph@9elements.com, rfoss@kernel.org, soc@kernel.org,
tzimmermann@suse.de
Subject: Re: [PATCH v5 08/11] devm-helpers: Add resource managed version of debugfs directory create function
Date: Mon, 25 Mar 2024 14:05:29 +0300 [thread overview]
Message-ID: <486947a7-98fc-4884-a5fd-354677fa66ce@moroto.mountain> (raw)
In-Reply-To: <f7c64a5a-2abc-4b7e-95db-7ca57b5427c0@wanadoo.fr>
On Sat, Mar 23, 2024 at 10:10:40PM +0100, Christophe JAILLET wrote:
> > static int pvt_ts_dbgfs_create(struct pvt_device *pvt, struct device *dev)
> > {
> > - pvt->dbgfs_dir = debugfs_create_dir(dev_name(dev), NULL);
> > + pvt->dbgfs_dir = devm_debugfs_create_dir(dev, dev_name(dev), NULL);
> > + if (IS_ERR(pvt->dbgfs_dir))
> > + return PTR_ERR(pvt->dbgfs_dir);
>
> Not sure if the test and error handling should be added here.
Yep. debugfs_create_dir() is not supposed to be checked here. It
breaks the driver if CONFIG_DEBUGFS is disabled. I have written a blog
about this:
https://staticthinking.wordpress.com/2023/07/24/debugfs-functions-are-not-supposed-to-be-checked/
regards,
dan carpenter
prev parent reply other threads:[~2024-03-25 11:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-23 16:43 [PATCH v5 00/11] Turris Omnia MCU driver Marek Behún
2024-03-23 16:43 ` [PATCH v5 06/11] devm-helpers: Add resource managed version of irq_create_mapping() Marek Behún
2024-03-25 9:40 ` Matti Vaittinen
2024-03-25 9:57 ` Marek Behún
2024-03-26 9:00 ` Dan Carpenter
2024-03-27 9:34 ` Marek Behún
2024-03-27 11:39 ` Dan Carpenter
2024-03-23 16:43 ` [PATCH v5 07/11] platform: cznic: turris-omnia-mcu: Add support for MCU provided TRNG Marek Behún
2024-03-23 16:43 ` [PATCH v5 08/11] devm-helpers: Add resource managed version of debugfs directory create function Marek Behún
2024-03-23 17:21 ` Guenter Roeck
2024-03-23 16:43 ` [PATCH v5 09/11] platform: cznic: turris-omnia-mcu: Add support for digital message signing via debugfs Marek Behún
[not found] ` <20240323164359.21642-9-kabel__6885.49310886941$1711212291$gmane$org@kernel.org>
2024-03-23 21:10 ` [PATCH v5 08/11] devm-helpers: Add resource managed version of debugfs directory create function Christophe JAILLET
2024-03-23 21:25 ` Marek Behún
2024-03-24 9:21 ` Christophe JAILLET
2024-03-24 15:08 ` Marek Behún
2024-03-25 11:05 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486947a7-98fc-4884-a5fd-354677fa66ce@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=bamv2005@gmail.com \
--cc=brgl@bgdev.pl \
--cc=christophe.jaillet@wanadoo.fr \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eajames@linux.ibm.com \
--cc=gaurav.jain@nxp.com \
--cc=gregory.clement@bootlin.com \
--cc=hdegoede@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@nxp.com \
--cc=james.clark@arm.com \
--cc=james@equiv.tech \
--cc=jdelvare@suse.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kabel@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mazziesaccount@gmail.com \
--cc=mripard@kernel.org \
--cc=naresh.solanki@9elements.com \
--cc=neil.armstrong@linaro.org \
--cc=pankaj.gupta@nxp.com \
--cc=patrick.rudolph@9elements.com \
--cc=rfoss@kernel.org \
--cc=soc@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox