Linux cryptographic layer development
 help / color / mirror / Atom feed
From: "Tatu Heikkilä" <tatu.heikkila@gmail.com>
To: herbert@gondor.apana.org.au
Cc: agk@redhat.com, bagasdotme@gmail.com, dm-devel@redhat.com,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	regressions@lists.linux.dev, snitzer@kernel.org
Subject: Re: [PATCH] dm crypt: Fix reqsize in crypt_iv_eboiv_gen
Date: Fri, 6 Oct 2023 14:03:35 +0300	[thread overview]
Message-ID: <48b3624d-ef0c-96e7-ff3d-9f34eb1caad8@gmail.com> (raw)
In-Reply-To: <ZR9l446ndB4n1Xl4@gondor.apana.org.au>

On Fri, Oct 06, 2023 at 09:41:55 +0800, Herbert Xu wrote:
>
> On Fri, Oct 06, 2023 at 08:04:18AM +0700, Bagas Sanjaya wrote:
> >
> > > Git bisect lead me to:
> > > # first bad commit: [e3023094dffb41540330fb0c74cd3a019cd525c2] dm crypt:
> > > Avoid using MAX_CIPHER_BLOCKSIZE
> > > 
> > > If I git revert e3023094dffb41540330fb0c74cd3a019cd525c2 on current Linus'
> > > git master, the issue goes away. So I'm personally not all that affected
> > > anymore (if I'm ready to compile my kernels from now on), and I understand
> > > that you have no clear way to reproduce this as it seems strongly bound to
> > > hardware, but seems like this could point to a potentially serious security
> > > issue since it involves both crypto and undefined behaviour.
> 
> Thanks for the report.  Sorry this is indeed my fault.  The allocated
> buffer is too small as it's missing the size for the request object
> itself.

Thank you for your prompt fix, I can access the volume without issue now. :-)
-Tatu


      parent reply	other threads:[~2023-10-06 11:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <f1b8d8f5-2079-537e-9d0f-d58da166fe50@gmail.com>
     [not found] ` <ZR9dEiXhQv-wBVA2@debian.me>
2023-10-06  1:41   ` [PATCH] dm crypt: Fix reqsize in crypt_iv_eboiv_gen Herbert Xu
2023-10-06  2:26     ` Mike Snitzer
2023-10-06  2:33       ` Herbert Xu
2023-10-06  8:20         ` Linux regression tracking (Thorsten Leemhuis)
2023-10-06 11:03     ` Tatu Heikkilä [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48b3624d-ef0c-96e7-ff3d-9f34eb1caad8@gmail.com \
    --to=tatu.heikkila@gmail.com \
    --cc=agk@redhat.com \
    --cc=bagasdotme@gmail.com \
    --cc=dm-devel@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=regressions@lists.linux.dev \
    --cc=snitzer@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox