From: Stephan Mueller <smueller@chronox.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: mathew.j.martineau@linux.intel.com, linux-crypto@vger.kernel.org
Subject: Re: [PATCH 2/3] crypto: AF_ALG - disregard AAD buffer space for output
Date: Tue, 15 Nov 2016 20:06:47 +0100 [thread overview]
Message-ID: <4916573.RdN3EB8qT2@positron.chronox.de> (raw)
In-Reply-To: <20161112021302.GA32425@gondor.apana.org.au>
Am Samstag, 12. November 2016, 10:13:02 CET schrieb Herbert Xu:
Hi Herbert,
> On Sat, Nov 12, 2016 at 03:03:36AM +0100, Stephan Mueller wrote:
> > When you have separate buffers, the kernel does not seem to copy the AD
> > over to the target buffer.
>
> OK we should definitely fix that.
Shall the fix be rolled into the patch together with the fix for the tag value
as well as the crash fix? Or can we have a stand-alone patch fixing this.
Btw., how do you suggest that should be fixed? I would assume that this needs
to be fixed on a per-implementation basis. I tested authenc and it copies the
buffers over. gcm_base(ctr-aes-aesni,ghash-clmulni), rfc4106-gcm-aesni or
ccm_base(ctr-aes-aesni,aes-aesni) do not copy the AD over.
Ciao
Stephan
next prev parent reply other threads:[~2016-11-15 19:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 3:30 [PATCH 0/3] crypto: AF_ALG - AEAD memory handling fixes Stephan Mueller
2016-11-10 3:31 ` [PATCH 1/3] crypto: AF_ALG - fix AEAD tag memory handling Stephan Mueller
2016-11-10 3:32 ` [PATCH 2/3] crypto: AF_ALG - disregard AAD buffer space for output Stephan Mueller
2016-11-12 0:26 ` Mat Martineau
2016-11-12 2:12 ` Stephan Mueller
2016-11-12 1:55 ` Herbert Xu
2016-11-12 2:03 ` Stephan Mueller
2016-11-12 2:13 ` Herbert Xu
2016-11-15 19:06 ` Stephan Mueller [this message]
2016-11-16 8:57 ` Herbert Xu
2016-11-16 8:59 ` Herbert Xu
2016-11-16 9:02 ` Stephan Mueller
2016-11-16 9:04 ` Herbert Xu
2016-11-19 21:08 ` Stephan Mueller
2016-11-28 11:39 ` Herbert Xu
2016-11-16 9:05 ` Herbert Xu
2016-11-10 3:32 ` [PATCH 3/3] crypto: AF_ALG - fix AEAD AIO handling of zero buffer Stephan Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4916573.RdN3EB8qT2@positron.chronox.de \
--to=smueller@chronox.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).