* Re: [PATCH] crypto: des: fix inverted weak key flag check
[not found] <200812041555.22429.jarod@redhat.com>
@ 2008-12-05 14:54 ` Jarod Wilson
0 siblings, 0 replies; only message in thread
From: Jarod Wilson @ 2008-12-05 14:54 UTC (permalink / raw)
To: linux-crypto; +Cc: Neil Horman, Herbert Xu, linux-kernel
Jarod Wilson wrote:
> Based on the fact the testmgr code sets the weak key flag for
> vectors with wk = 1, the weak key flag check in des_setkey()
> is backwards. Also, add a warning when a weak key is rejected,
> otherwise you silently get a bogus result back.
>
> Signed-off-by: Jarod Wilson <jarod@redhat.com>
Self-NAK. Due to mail server issues, this might show up before the
original...
My understanding of the flag's meaning appears to be backwards, Herbert
pointed out that the use of this flag is self-consistent. Also, the
printk probably shouldn't be there, the caller should check retval and
complain if need be.
--
Jarod Wilson
jarod@redhat.com
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-12-05 14:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200812041555.22429.jarod@redhat.com>
2008-12-05 14:54 ` [PATCH] crypto: des: fix inverted weak key flag check Jarod Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).