From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frank Seidel Subject: Re: [PATCH][trivial] crypto: tcrypt - reduce stack size Date: Wed, 25 Feb 2009 15:36:33 +0100 Message-ID: <49A55771.1050408@suse.de> References: <49A54C23.8090209@suse.de> <20090225142000.GA4136@gondor.apana.org.au> <49A55499.6090700@suse.de> <20090225142744.GA4331@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Herbert Xu , linux kernel , linux-crypto@vger.kernel.org, Frank Seidel , akpm@linux-foundation.org, "David S. Miller" , nhorman@tuxdriver.com, lho@amcc.com, kaber@trash.net, darrenrjenkins@gmail.com, Greg KH To: Geert Uytterhoeven Return-path: Received: from mx2.suse.de ([195.135.220.15]:34965 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754345AbZBYOgg (ORCPT ); Wed, 25 Feb 2009 09:36:36 -0500 In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: Geert Uytterhoeven wrote: > Probably people should be reminded tcrypt can only be a module, not built-in, > so it won't waste precious unswappable kernel memory if it's static. Thats right, but it also doesn't hurt to simply use kmalloc, does it? :-) I just stumbled over tcrypt on the make checkstack output and as also the kerneljanitors todo advises to reduce this footprint where possible i just wanted to help out here. Thanks, Frank