From: "Séguier Régis" <rseguier@e-teleport.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org
Subject: Re: Padlock SHA1 failed at boot time
Date: Tue, 22 Sep 2009 19:34:17 +0200 [thread overview]
Message-ID: <4AB90A99.6040008@e-teleport.net> (raw)
In-Reply-To: <20090922171716.GA2977@gondor.apana.org.au>
Herbert Xu a écrit :
> Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
>> crypto: padlock-sha - Fix stack alignment
>>
>> The PadLock hardware requires the output buffer for SHA to be
>> 128-bit aligned. We currentply place the buffer on the stack,
>> and ask gcc to align it to 128 bits. That doesn't work on i386
>> because the kernel stack is only aligned to 32 bits. This patch
>> changes the code to align the buffer by hand so that the hardware
>> doesn't fault on unaligned buffers.
>>
>> Reported-by: Séguier Régis <rguier@e-teleport.net>
>> Tested-by: Séguier Régis <rguier@e-teleport.net>
>> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>>
>
> For the record I modified the patch slightly to ensure that
> we get the minimum alignment from gcc
Ok, tested, good for me.
Just, not important, my mail is not rguier@e-teleport.net but
rseguier@e-teleport.net for the changelog.
--
Régis Séguier
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-09-22 17:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-20 16:23 Padlock SHA1 failed at boot time Séguier Régis
2009-09-21 6:13 ` Herbert Xu
2009-09-21 7:49 ` Séguier Régis
2009-09-22 1:56 ` Herbert Xu
2009-09-22 17:17 ` Herbert Xu
2009-09-22 17:34 ` Séguier Régis [this message]
2009-09-23 5:27 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB90A99.6040008@e-teleport.net \
--to=rseguier@e-teleport.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox