From: Dmitry Kasatkin <dmitry.kasatkin@nokia.com>
To: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Possible bug: blkcipher_walk_done()
Date: Wed, 10 Feb 2010 11:42:13 +0200 [thread overview]
Message-ID: <4B727F75.20305@nokia.com> (raw)
Hi,
It seems that there is a mistake in the implementation of
int blkcipher_walk_done(struct blkcipher_desc *desc,
struct blkcipher_walk *walk, int err)
blkcipher_walk_virt() will call crypto_kmap() to map page.
But in the case then err argument is < 0 and we cannot continue then
blkcipher_walk_done() will not
unmap the page.
What do you think?
- Dmitry
next reply other threads:[~2010-02-10 9:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 9:42 Dmitry Kasatkin [this message]
2010-02-14 5:47 ` Possible bug: blkcipher_walk_done() Herbert Xu
2010-02-15 19:02 ` Dmitry Kasatkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B727F75.20305@nokia.com \
--to=dmitry.kasatkin@nokia.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox