From: Dmitry Kasatkin <dmitry.kasatkin@nokia.com>
To: ext Herbert Xu <herbert@gondor.hengli.com.au>
Cc: Uri Simchoni <uri@jdland.co.il>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 & MD5 driver
Date: Tue, 13 Apr 2010 13:13:47 +0300 [thread overview]
Message-ID: <4BC443DB.1030602@nokia.com> (raw)
In-Reply-To: <20100413100308.GA9600@gondor.apana.org.au>
Hi
On 13/04/10 13:03, ext Herbert Xu wrote:
> On Tue, Apr 13, 2010 at 12:39:55PM +0300, Dmitry Kasatkin wrote:
>
>> btw. patch to mv_cesa is actually adding hmac to the driver.
>> How would you comment that?
>>
> AFAICS it's doing HMAC in hardware. Uri, is that not the case?
>
>
As I can see from the patch initial vectors calculated with SW shash
Rest is done in hw, basically sha1.
The same can be done with omap driver.
Just in addition to finalize as done in hmac_final().
crypto_shash_import(desc, opad) ?:
crypto_shash_finup(desc, out, ds, req->result);
>> The same way could be also used here.
>>
> If your hardware supports HMAC that would definitely be the way
> to go.
>
> Cheers,
>
next prev parent reply other threads:[~2010-04-13 10:14 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 16:35 [PATCH 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 & MD5 driver Dmitry.Kasatkin
2010-04-13 8:59 ` Herbert Xu
2010-04-13 9:39 ` Dmitry Kasatkin
2010-04-13 10:03 ` Herbert Xu
2010-04-13 10:13 ` Dmitry Kasatkin [this message]
2010-04-13 12:02 ` Herbert Xu
2010-04-13 13:00 ` Dmitry Kasatkin
2010-04-13 14:45 ` Herbert Xu
2010-04-13 15:16 ` Uri Simchoni
2010-04-13 15:21 ` Dmitry Kasatkin
2010-04-14 0:44 ` Herbert Xu
2010-04-14 6:37 ` Dmitry Kasatkin
2010-04-14 6:44 ` Herbert Xu
2010-04-14 6:51 ` Dmitry Kasatkin
2010-04-14 6:55 ` Herbert Xu
2010-04-16 7:44 ` Dmitry Kasatkin
2010-04-19 13:27 ` Herbert Xu
2010-04-13 10:15 ` Dmitry Kasatkin
2010-04-13 12:00 ` Uri Simchoni
2010-04-13 12:10 ` Herbert Xu
2010-04-13 13:44 ` Dmitry Kasatkin
2010-04-13 14:36 ` Dmitry Kasatkin
2010-04-13 14:42 ` Herbert Xu
2010-04-13 15:33 ` Dmitry Kasatkin
2010-04-14 0:47 ` Herbert Xu
2010-04-13 14:48 ` Herbert Xu
2010-04-13 15:48 ` Dmitry Kasatkin
2010-04-14 0:50 ` Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2010-03-17 13:12 Dmitry Kasatkin
2010-03-23 11:32 ` Herbert Xu
2010-03-24 7:31 ` Dmitry Kasatkin
2010-03-24 14:51 ` Dmitry Kasatkin
2010-04-08 14:07 ` Herbert Xu
2010-04-08 14:04 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC443DB.1030602@nokia.com \
--to=dmitry.kasatkin@nokia.com \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-crypto@vger.kernel.org \
--cc=uri@jdland.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).