From: Dmitry Kasatkin <dmitry.kasatkin@nokia.com>
To: ext Uri Simchoni <uri@jdland.co.il>
Cc: Herbert Xu <herbert@gondor.hengli.com.au>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 & MD5 driver
Date: Tue, 13 Apr 2010 18:21:44 +0300 [thread overview]
Message-ID: <4BC48C08.7040608@nokia.com> (raw)
In-Reply-To: <4BC48AE1.4010103@jdland.co.il>
On 13/04/10 18:16, ext Uri Simchoni wrote:
> Doing step 3 using sw is probably faster than by hw (because it's short and avoid all the hw setup), so the suggested approach is probably faster than generic async hmac.
>
>
Yes. that is exactly what happens in hw - it is much slower.
And I do not see any problems as well with finishing it with sw.
> On 4/13/2010 5:45 PM, Herbert Xu wrote:
>
>> On Tue, Apr 13, 2010 at 04:00:11PM +0300, Dmitry Kasatkin wrote:
>>
>>> I would also:
>>> 1. calc hash(opad) using sw, export
>>> 2. hash(ipad ∥ message) using hw
>>> 3. then import and finup hash from step 1 with results of step 2 (using sw)
>>>
>> Step 3 is the problem. If you perform step 3 in software then
>> there is no point in exporting a hmac(sha1) object.
>>
>> We should instead add ahash support to hmac and use that.
>>
>> Cheers,
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-04-13 15:22 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 16:35 [PATCH 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 & MD5 driver Dmitry.Kasatkin
2010-04-13 8:59 ` Herbert Xu
2010-04-13 9:39 ` Dmitry Kasatkin
2010-04-13 10:03 ` Herbert Xu
2010-04-13 10:13 ` Dmitry Kasatkin
2010-04-13 12:02 ` Herbert Xu
2010-04-13 13:00 ` Dmitry Kasatkin
2010-04-13 14:45 ` Herbert Xu
2010-04-13 15:16 ` Uri Simchoni
2010-04-13 15:21 ` Dmitry Kasatkin [this message]
2010-04-14 0:44 ` Herbert Xu
2010-04-14 6:37 ` Dmitry Kasatkin
2010-04-14 6:44 ` Herbert Xu
2010-04-14 6:51 ` Dmitry Kasatkin
2010-04-14 6:55 ` Herbert Xu
2010-04-16 7:44 ` Dmitry Kasatkin
2010-04-19 13:27 ` Herbert Xu
2010-04-13 10:15 ` Dmitry Kasatkin
2010-04-13 12:00 ` Uri Simchoni
2010-04-13 12:10 ` Herbert Xu
2010-04-13 13:44 ` Dmitry Kasatkin
2010-04-13 14:36 ` Dmitry Kasatkin
2010-04-13 14:42 ` Herbert Xu
2010-04-13 15:33 ` Dmitry Kasatkin
2010-04-14 0:47 ` Herbert Xu
2010-04-13 14:48 ` Herbert Xu
2010-04-13 15:48 ` Dmitry Kasatkin
2010-04-14 0:50 ` Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2010-03-17 13:12 Dmitry Kasatkin
2010-03-23 11:32 ` Herbert Xu
2010-03-24 7:31 ` Dmitry Kasatkin
2010-03-24 14:51 ` Dmitry Kasatkin
2010-04-08 14:07 ` Herbert Xu
2010-04-08 14:04 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC48C08.7040608@nokia.com \
--to=dmitry.kasatkin@nokia.com \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-crypto@vger.kernel.org \
--cc=uri@jdland.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).