linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andre Bubel <news@andre-bubel.de>
To: linux-crypto@vger.kernel.org
Cc: Mario.Holbe@TU-Ilmenau.DE
Subject: Re: VIA Padlock: +30% XTS Performance by using ECB
Date: Sun, 16 May 2010 19:34:46 +0200	[thread overview]
Message-ID: <4BF02CB6.5020707@andre-bubel.de> (raw)
In-Reply-To: <20100423154449.GA1138@darkside.12.kls.lan>

On 23.04.2010 17:44, Mario 'BitKoenig' Holbe wrote:
> Hello,

Hi Mario,

> the VIA Padlock engine comes without native XTS-AES support, thus
> compared to CBC-AES or ECB-AES XTS-AES performs quite bad on VIA CPUs
> because it calls the Padlock ACE for each single AESenc() operation.
> Using the Padlock's ECB-AES saves calls to the Padlock ACE and improves
> the XTS-AES performance by 30% and more even in a naive proof-of-concept
> implementation.
> The idea comes from DiskCryptor which does this since v0.9.583.106.

The same problem exists with the mv_cesa driver. I really like to have a 
solution for this as the performance of the system is mainly cripled by 
the hard disk encryption.

> I have no idea where this should finally be implemented, since it slows
> down XTS on non-accelerated CPUs. Maybe a seperate xts-aes-padlock
> driver would make sense depending on how specific this is to VIA
> Padlock, i.e. how it performs on other non-XTS-capable accelerators.

I'm currently trying to get an understanding of the kernel crypto code, 
but my impression is that instead of breaking support with the 
synchronous API the better way would be to introduce asynchronous 
ciphers (e.g. acipher) that can be used transparently by crypto_template 
implementations to form an ablkcipher. In that way all crypto modes 
would be supported and accelerated through hardware, even if it doesn't 
provide an in-hardware implementation.

As I mentioned I'm new to the kernel API, so what is the opinion of 
experienced developers on this? Is that in reach of the current API 
architecture?

> Please CC: me in replies, I'm not a member of the list. Mail-F'up2
> should be set correctly.

Best regards,
André Bubel

  reply	other threads:[~2010-05-16 17:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-23 15:44 VIA Padlock: +30% XTS Performance by using ECB Mario 'BitKoenig' Holbe
2010-05-16 17:34 ` Andre Bubel [this message]
2010-05-19  5:07 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BF02CB6.5020707@andre-bubel.de \
    --to=news@andre-bubel.de \
    --cc=Mario.Holbe@TU-Ilmenau.DE \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).