From: Dmitry Kasatkin <dmitry.kasatkin@nokia.com>
To: ext Herbert Xu <herbert@gondor.hengli.com.au>
Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Re: crypto ahash error handling
Date: Thu, 11 Nov 2010 20:11:21 +0200 [thread overview]
Message-ID: <4CDC31C9.8070002@nokia.com> (raw)
In-Reply-To: <20101111161707.GA32431@gondor.apana.org.au>
Hi,
Yes. Our HW is capable of producing unfinalised hashes.
Everything is fine.
No. It is not broken.. It cleans up if error...
- Dmitry
On 11/11/10 18:17, ext Herbert Xu wrote:
> On Wed, Nov 10, 2010 at 04:54:51PM +0200, Dmitry Kasatkin wrote:
>
>> This is not good.
>>
>> Driver might allocate some resources, which needs to be released.
>> crypto_ahash_final() should do some kind of "cleanup" task.
>>
> Then your driver is broken. The whole hash API is designed around
> the fact that each update operation completely stores all output
> state in the memory provided, leaving no state behind in the
> hardware.
>
> Is your hardware capable of producing unfinalised hashes? If not
> then you shouldn't even be implementing an update operation in
> hardware. You should instead use a software fallback.
>
> Cheers,
>
next prev parent reply other threads:[~2010-11-11 18:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-08 8:48 crypto ahash error handling Dmitry Kasatkin
2010-11-10 12:27 ` Herbert Xu
2010-11-10 14:54 ` Dmitry Kasatkin
2010-11-11 16:17 ` Herbert Xu
2010-11-11 18:11 ` Dmitry Kasatkin [this message]
2010-11-12 0:05 ` Herbert Xu
2010-11-12 11:30 ` Dmitry Kasatkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDC31C9.8070002@nokia.com \
--to=dmitry.kasatkin@nokia.com \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).