From: Dmitry Kasatkin <dmitry.kasatkin@nokia.com>
To: ext Herbert Xu <herbert@gondor.hengli.com.au>
Cc: <linux-crypto@vger.kernel.org>
Subject: Re: hash finup() issue
Date: Wed, 26 Jan 2011 09:47:27 +0200 [thread overview]
Message-ID: <4D3FD18F.2020905@nokia.com> (raw)
In-Reply-To: <20110125232917.GA14972@gondor.apana.org.au>
I am not talking about user space API at all.
I talk about kernel crypto API and kernel clients.
Please understand the following: when update() is called driver does not
know if it is last update or not...
That is essential.
If client code would always use update/finup then it is fine..
But original API and clients uses update/final...
That is why some way (flag) needed to tell if finup() will be used or not...
It gave up 20% performance improvement in some case because no extra
memcpy has been done...
If you think about other solution, please share...
Have a nice day,
- Dmitry
On 26/01/11 01:29, ext Herbert Xu wrote:
> On Tue, Jan 25, 2011 at 03:44:47PM +0200, Dmitry Kasatkin wrote:
>> What we have done in our system is introduced a new flag which is set to
>> request.
>> flags |= CRYPTO_TFM_REQ_USE_FINUP;
>> ahash_request_set_callback(req, flags, tcrypt_complete, &tresult);
> We don't need a flag for this, we just need to optimise the
> user-interface code to actually use finup when MSG_MORE is not
> set.
>
> Cheers,
next prev parent reply other threads:[~2011-01-26 7:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 13:44 hash finup() issue Dmitry Kasatkin
2011-01-25 23:29 ` Herbert Xu
2011-01-26 7:47 ` Dmitry Kasatkin [this message]
2011-01-26 23:32 ` Herbert Xu
2011-01-27 6:47 ` Dmitry Kasatkin
2011-01-27 7:18 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3FD18F.2020905@nokia.com \
--to=dmitry.kasatkin@nokia.com \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox