linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@xenotime.net>
To: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	linux-next@vger.kernel.org,
	Herbert Xu <herbert@gondor.apana.org.au>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: serpent-sse2 - should select CRYPTO_CRYPTD
Date: Thu, 24 Nov 2011 10:35:29 -0800	[thread overview]
Message-ID: <4ECE8E71.1080606@xenotime.net> (raw)
In-Reply-To: <20111124063741.17986.23462.stgit@localhost6.localdomain6>

On 11/23/2011 10:37 PM, Jussi Kivilinna wrote:
> Since serpent_sse2_glue.c uses cryptd, CRYPTO_SERPENT_SSE2_X86_64 and
> CRYPTO_SERPENT_SSE2_586 should be selecting CRYPTO_CRYPTD.
> 
> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
> Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>

Acked-by: Randy Dunlap <rdunlap@xenotime.net>

Thanks.

> ---
>  crypto/Kconfig |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index 16e0c13..b8d1b10 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -770,6 +770,7 @@ config CRYPTO_SERPENT_SSE2_X86_64
>  	tristate "Serpent cipher algorithm (x86_64/SSE2)"
>  	depends on X86 && 64BIT
>  	select CRYPTO_ALGAPI
> +	select CRYPTO_CRYPTD
>  	select CRYPTO_SERPENT
>  	help
>  	  Serpent cipher algorithm, by Anderson, Biham & Knudsen.
> @@ -787,6 +788,7 @@ config CRYPTO_SERPENT_SSE2_586
>  	tristate "Serpent cipher algorithm (i586/SSE2)"
>  	depends on X86 && !64BIT
>  	select CRYPTO_ALGAPI
> +	select CRYPTO_CRYPTD
>  	select CRYPTO_SERPENT
>  	help
>  	  Serpent cipher algorithm, by Anderson, Biham & Knudsen.
> 


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

  reply	other threads:[~2011-11-24 18:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20111123154432.30e6358f2b0206f82c489279@canb.auug.org.au>
2011-11-23 20:07 ` linux-next: Tree for Nov 23 (crypto) Randy Dunlap
2011-11-24  6:37   ` [PATCH] crypto: serpent-sse2 - should select CRYPTO_CRYPTD Jussi Kivilinna
2011-11-24 18:35     ` Randy Dunlap [this message]
2011-11-30  8:18       ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ECE8E71.1080606@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=jussi.kivilinna@mbnet.fi \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).