Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Nikos Mavrogiannopoulos <nmav@gnutls.org>
To: Herbert Xu <herbert@gondor.hengli.com.au>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH 1/1] Added CRYPTO_ALG_KERN_DRIVER_ONLY flag (3rd attempt)
Date: Fri, 06 Jan 2012 09:19:01 +0100	[thread overview]
Message-ID: <4F06AE75.9050806@gnutls.org> (raw)
In-Reply-To: <20120106013701.GA6484@gondor.apana.org.au>

On 01/06/2012 02:37 AM, Herbert Xu wrote:

> Nikos Mavrogiannopoulos <nmav@gnutls.org> wrote:
>> The added CRYPTO_ALG_KERN_DRIVER_ONLY indicates whether a cipher
>> is only available via a kernel driver. If the cipher implementation
>> might be available by using an instruction set or by porting the
>> kernel code, then it must not be set.
[...]
>> +static inline u32 crypto_tfm_alg_flags(struct crypto_tfm *tfm)
>> +{
>> +       return tfm->__crt_alg->cra_flags;
>> +}
>> +
> Who is going to use this? For one it's not type-safe as we try
> to avoid directly using crypto_tfm in kernel code.


I needed this function in order to access the new flag without
relying on the structure format. The available crypto_tfm_alg_type() 
would apply a mask and remove it, thus I added this function.

regards,
Nikos

  reply	other threads:[~2012-01-06  8:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-13  8:53 [PATCH 1/1] Added CRYPTO_ALG_KERN_DRIVER_ONLY flag (2nd attempt) Nikos Mavrogiannopoulos
2011-12-13 16:10 ` Kim Phillips
2011-12-13 20:34   ` [PATCH 1/1] Added CRYPTO_ALG_KERN_DRIVER_ONLY flag (3rd attempt) Nikos Mavrogiannopoulos
2012-01-06  1:37     ` Herbert Xu
2012-01-06  8:19       ` Nikos Mavrogiannopoulos [this message]
2012-01-06  8:28         ` Herbert Xu
2012-01-06  9:02           ` Nikos Mavrogiannopoulos
2012-01-06  9:12             ` Herbert Xu
2012-01-06  9:29               ` Nikos Mavrogiannopoulos
2012-01-06  9:32                 ` Herbert Xu
     [not found]                   ` <CAJU7zaJdXa0KU6801fYQd8pSeLRF0Ff=XjQiNd5d-9ngwZ==kg@mail.gmail.com>
     [not found]                     ` <20120106102359.GA9935@gondor.apana.org.au>
2012-01-06 21:24                       ` [PATCH 1/1] Added CRYPTO_ALG_KERN_DRIVER_ONLY flag (4rd attempt) Nikos Mavrogiannopoulos
2012-01-13  5:36                         ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F06AE75.9050806@gnutls.org \
    --to=nmav@gnutls.org \
    --cc=herbert@gondor.hengli.com.au \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox