Linux cryptographic layer development
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: Tim Chen <tim.c.chen@linux.intel.com>,
	Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	herbert@gondor.hengli.com.au, linux-kernel@vger.kernel.org,
	linux-crypto@vger.kernel.org, ak <ak@linux.intel.com>,
	rjw@rjwysocki.net
Subject: Re: [PATCH 3.11-rc1] crypto: Fix boot failure due to module dependency.
Date: Thu, 18 Jul 2013 16:44:20 -0700	[thread overview]
Message-ID: <51E87DD4.3000907@zytor.com> (raw)
In-Reply-To: <51E8696A.7090406@intel.com>

On 07/18/2013 03:17 PM, Rafael J. Wysocki wrote:
>>
>> alias x86cpu:vendor:*:family:*:model:*:feature:*0081* crct10dif_pclmul
>>
>> This should cause udev to load the crct10dif_pclml module when cpu
>> support the PCLMULQDQ (feature code 0081).  I did my testing during
>> development on 3.10 and the module was indeed loaded.
>>
>> However, I found that the following commit under 3.11-rc1 broke
>> the mechanism after some bisection.
>>
>> commit ac212b6980d8d5eda705864fc5a8ecddc6d6eacc
>> Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>> Date:   Fri May 3 00:26:22 2013 +0200
>>
>>      ACPI / processor: Use common hotplug infrastructure
>>           Split the ACPI processor driver into two parts, one that is
>>      non-modular, resides in the ACPI core and handles the enumeration
>>      and hotplug of processors and one that implements the rest of the
>>      existing processor driver functionality.
>>      Rafael, can you check and see if this can be fixed so those
>> optimized
>> crypto modules for Intel cpu that support them can be loaded?
> 
> I think this is an ordering issue between udev startup and the time when
> devices are registered.
> 
> I wonder what happens if you put those modules into the initramfs image?
> 

OK, this bothers me on some pretty deep level... a set of changes
exclusively in drivers/acpi breaking functionality which had nothing to
do with ACPI, specifically CPU-feature-based module loading.

Please let me know what the investigation comes up with, or if I need to
get more directly involved.

	-hpa

  parent reply	other threads:[~2013-07-18 23:44 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201307162053.GBC56724.MFVOJtSLQHFOOF@I-love.SAKURA.ne.jp>
     [not found] ` <20130716115527.GA1034@gondor.apana.org.au>
     [not found]   ` <201307162249.JEA41532.FFOLHVQJFtOOMS@I-love.SAKURA.ne.jp>
2013-07-16 16:23     ` [PATCH 3.11-rc1] crypto: Fix boot failure due to moduledependency Tim Chen
2013-07-17 11:52       ` [PATCH 3.11-rc1] crypto: Fix boot failure due tomoduledependency Tetsuo Handa
2013-07-17 16:46         ` Tim Chen
2013-07-17 20:50           ` [PATCH 3.11-rc1] crypto: Fix boot failure duetomoduledependency Tetsuo Handa
2013-07-17 21:53             ` Tim Chen
2013-07-17 22:08             ` Tim Chen
2013-07-18  3:47               ` [PATCH 3.11-rc1] crypto: Fix boot failure due to module dependency Tetsuo Handa
2013-07-18 21:00                 ` Tim Chen
2013-07-18 22:17                   ` Rafael J. Wysocki
2013-07-18 23:08                     ` Tim Chen
2013-07-19 13:03                       ` Rafael J. Wysocki
2013-07-19 14:49                         ` Rafael J. Wysocki
2013-07-19 18:08                           ` Tim Chen
2013-07-19 21:38                             ` Rafael J. Wysocki
2013-07-19 23:16                               ` Greg Kroah-Hartman
2013-07-19 23:21                                 ` H. Peter Anvin
2013-07-19 23:24                                   ` Herbert Xu
2013-07-19 23:37                                     ` Tim Chen
2013-07-20  1:31                                       ` Tim Chen
2013-07-20  2:19                                         ` [PATCH 3.11-rc1] crypto: Fix boot failure due to moduledependency Tetsuo Handa
2013-07-20  5:30                                         ` [PATCH 3.11-rc1] crypto: Fix boot failure due to module dependency Herbert Xu
2013-07-20  5:56                                           ` [PATCH 3.11-rc1] crypto: Fix boot failure due to moduledependency Tetsuo Handa
     [not found]                                             ` <201309112043.HBD04609.FOtLSOFVQHFOJM@I-love.SAKURA.ne.jp>
     [not found]                                               ` <20130912042622.GA15181@gondor.apana.org.au>
     [not found]                                                 ` <201309121403.FIH09821.JtLOVOSFOFHFQM@I-love.SAKURA.ne.jp>
2013-09-12  5:28                                                   ` [3.12-rc1] Dependency on module-init-tools >= 3.11 ? Herbert Xu
2013-09-12 10:20                                                     ` Tetsuo Handa
2013-09-12 10:29                                                       ` Herbert Xu
2013-09-12 14:26                                                         ` Waiman Long
2013-09-13 13:27                                                           ` Tetsuo Handa
2013-07-19 23:26                                   ` [PATCH 3.11-rc1] crypto: Fix boot failure due to module dependency Greg Kroah-Hartman
2013-07-19 23:28                                     ` H. Peter Anvin
2013-07-20  0:00                                 ` Rafael J. Wysocki
2013-07-20  3:06                                   ` Rafael J. Wysocki
2013-07-20  9:51                                     ` Rafael J. Wysocki
2013-07-20 11:01                                       ` Rafael J. Wysocki
2013-07-18 23:44                     ` H. Peter Anvin [this message]
2013-07-19 12:57                       ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E87DD4.3000907@zytor.com \
    --to=hpa@zytor.com \
    --cc=ak@linux.intel.com \
    --cc=herbert@gondor.hengli.com.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rjw@rjwysocki.net \
    --cc=tim.c.chen@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox