From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: devicetree@vger.kernel.org,
Stephen Warren <swarren@wwwdotorg.org>,
Rob Herring <rob.herring@calxeda.com>,
linux-crypto@vger.kernel.org,
Tobias Rauter <tobiasrauter@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] crypto: dcp: rename 'compatible' property to 'fsl,dcp'
Date: Thu, 08 Aug 2013 23:39:47 +0400 [thread overview]
Message-ID: <5203F403.1040800@cogentembedded.com> (raw)
In-Reply-To: <1375968629-10091-4-git-send-email-LW@KARO-electronics.de>
Hello.
On 08/08/2013 05:30 PM, Lothar Waßmann wrote:
> Leave the old 'fsl-dcp' value in place with an appropriate comment
> until external users have updated their DTBs.
> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
> ---
> arch/arm/boot/dts/imx28.dtsi | 2 +-
> drivers/crypto/dcp.c | 2 ++
> 2 files changed, 3 insertions(+), 1 deletions(-)
> diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> index ea99d09..0584935 100644
> --- a/arch/arm/boot/dts/imx28.dtsi
> +++ b/arch/arm/boot/dts/imx28.dtsi
> @@ -794,7 +794,7 @@
> };
>
> dcp: dcp@80028000 {
By the way, I see that this is a crypto device, so it should be named
"crypto" according to ePAPR spec. [1]
> - compatible = "fsl-dcp";
> + compatible = "fsl,dcp";
> reg = <0x80028000 0x2000>;
> interrupts = <52 53 54>;
> status = "disabled";
[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
WBR, Sergei
next prev parent reply other threads:[~2013-08-08 19:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 13:30 [PATCH 0/3] ARM: dts: mxs: dcp cleanup patches Lothar Waßmann
2013-08-08 13:30 ` [PATCH 1/3] ARM: dts: mxs: set dcp to "disabled" by default Lothar Waßmann
2013-08-12 11:05 ` Shawn Guo
2013-08-12 12:05 ` Lothar Waßmann
2013-08-12 14:17 ` Kumar Gala
2013-08-08 13:30 ` [PATCH 2/3] crypto: dcp - cleanup: commas at end of struct initializers where appropriate Lothar Waßmann
2013-08-08 13:30 ` [PATCH 3/3] crypto: dcp: rename 'compatible' property to 'fsl,dcp' Lothar Waßmann
2013-08-08 19:39 ` Sergei Shtylyov [this message]
2013-08-08 21:14 ` [PATCH 0/3] ARM: dts: mxs: dcp cleanup patches Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5203F403.1040800@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=LW@KARO-electronics.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
--cc=tobiasrauter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox