* [PATCH] crypto: omap-des - make local functions static
@ 2014-02-27 11:34 Jingoo Han
2014-02-28 0:59 ` Joel Fernandes
0 siblings, 1 reply; 3+ messages in thread
From: Jingoo Han @ 2014-02-27 11:34 UTC (permalink / raw)
To: 'Herbert Xu'
Cc: 'David Miller', linux-crypto, 'Jingoo Han',
'Joel Fernandes'
Make omap_des_copy_needed(), omap_des_copy_sgs(), because these
functions are used only in this file.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/crypto/omap-des.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/omap-des.c b/drivers/crypto/omap-des.c
index 758919e..ec5f131 100644
--- a/drivers/crypto/omap-des.c
+++ b/drivers/crypto/omap-des.c
@@ -535,7 +535,7 @@ static int omap_des_crypt_dma_stop(struct omap_des_dev *dd)
return err;
}
-int omap_des_copy_needed(struct scatterlist *sg)
+static int omap_des_copy_needed(struct scatterlist *sg)
{
while (sg) {
if (!IS_ALIGNED(sg->offset, 4))
@@ -547,7 +547,7 @@ int omap_des_copy_needed(struct scatterlist *sg)
return 0;
}
-int omap_des_copy_sgs(struct omap_des_dev *dd)
+static int omap_des_copy_sgs(struct omap_des_dev *dd)
{
void *buf_in, *buf_out;
int pages;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] crypto: omap-des - make local functions static
2014-02-27 11:34 [PATCH] crypto: omap-des - make local functions static Jingoo Han
@ 2014-02-28 0:59 ` Joel Fernandes
2014-03-10 12:21 ` Herbert Xu
0 siblings, 1 reply; 3+ messages in thread
From: Joel Fernandes @ 2014-02-28 0:59 UTC (permalink / raw)
To: Jingoo Han, 'Herbert Xu'; +Cc: 'David Miller', linux-crypto
On 02/27/2014 05:34 AM, Jingoo Han wrote:
> Make omap_des_copy_needed(), omap_des_copy_sgs(), because these
> functions are used only in this file.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Ok with me,
Acked-by: Joel Fernandes <joelf@ti.com>
> ---
> drivers/crypto/omap-des.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/omap-des.c b/drivers/crypto/omap-des.c
> index 758919e..ec5f131 100644
> --- a/drivers/crypto/omap-des.c
> +++ b/drivers/crypto/omap-des.c
> @@ -535,7 +535,7 @@ static int omap_des_crypt_dma_stop(struct omap_des_dev *dd)
> return err;
> }
>
> -int omap_des_copy_needed(struct scatterlist *sg)
> +static int omap_des_copy_needed(struct scatterlist *sg)
> {
> while (sg) {
> if (!IS_ALIGNED(sg->offset, 4))
> @@ -547,7 +547,7 @@ int omap_des_copy_needed(struct scatterlist *sg)
> return 0;
> }
>
> -int omap_des_copy_sgs(struct omap_des_dev *dd)
> +static int omap_des_copy_sgs(struct omap_des_dev *dd)
> {
> void *buf_in, *buf_out;
> int pages;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] crypto: omap-des - make local functions static
2014-02-28 0:59 ` Joel Fernandes
@ 2014-03-10 12:21 ` Herbert Xu
0 siblings, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2014-03-10 12:21 UTC (permalink / raw)
To: Joel Fernandes; +Cc: Jingoo Han, 'David Miller', linux-crypto
On Thu, Feb 27, 2014 at 06:59:48PM -0600, Joel Fernandes wrote:
> On 02/27/2014 05:34 AM, Jingoo Han wrote:
> > Make omap_des_copy_needed(), omap_des_copy_sgs(), because these
> > functions are used only in this file.
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>
> Ok with me,
> Acked-by: Joel Fernandes <joelf@ti.com>
Patch applied.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-10 12:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-27 11:34 [PATCH] crypto: omap-des - make local functions static Jingoo Han
2014-02-28 0:59 ` Joel Fernandes
2014-03-10 12:21 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).