From: "Horia Geantă" <horia.geanta@freescale.com>
To: Cristian Stoica <cristian.stoica@freescale.com>
Cc: <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
<linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: testmgr.c: white space fix-ups on test_aead
Date: Fri, 8 Aug 2014 12:22:44 +0300 [thread overview]
Message-ID: <53E496E4.9070207@freescale.com> (raw)
In-Reply-To: <1406542283-11995-1-git-send-email-cristian.stoica@freescale.com>
On 7/28/2014 1:11 PM, Cristian Stoica wrote:
> This patch inverts two if conditions and allows removal of one
> tab-stop in their code-blocks. Only white-space clean-up follows.
>
> Signed-off-by: Cristian Stoica <cristian.stoica@freescale.com>
> ---
> crypto/testmgr.c | 498 +++++++++++++++++++++++++++----------------------------
> 1 file changed, 242 insertions(+), 256 deletions(-)
This increases readability and reduces number of lines, not to mention
cyclomatic complexity.
While here, could you do this also for other places, like __test_hash?
Thanks,
Horia
next prev parent reply other threads:[~2014-08-08 9:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 10:11 [PATCH] crypto: testmgr.c: white space fix-ups on test_aead Cristian Stoica
2014-08-08 9:22 ` Horia Geantă [this message]
2014-08-08 11:27 ` [PATCH 1/3] crypto: testmgr.c: white space removal on __test_hash Cristian Stoica
2014-08-08 11:27 ` [PATCH 2/3] crypto: testmgr.c: white space removal on __test_skcipher Cristian Stoica
2014-08-10 8:57 ` Horia Geantă
2014-08-11 6:33 ` Cristian Stoica
2014-08-08 11:27 ` [PATCH 3/3] crypto: testmgr.c: delay execution of set-up code Cristian Stoica
2014-08-25 12:40 ` [PATCH] crypto: testmgr.c: white space fix-ups on test_aead Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E496E4.9070207@freescale.com \
--to=horia.geanta@freescale.com \
--cc=cristian.stoica@freescale.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).