From: "Horia Geantă" <horia.geanta@freescale.com>
To: Kim Phillips <kim.phillips@freescale.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
<linux-crypto@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Carmen Iorga <carmen.iorga@freescale.com>,
Alexandru Porosanu <alexandru.porosanu@freescale.com>,
Vakul Garg <vakul@freescale.com>,
Ruchika Gupta <ruchika.gupta@freescale.com>
Subject: Re: [PATCH v2 00/12] crypto: caam - Add RTA descriptor creation library
Date: Wed, 3 Sep 2014 12:59:34 +0300 [thread overview]
Message-ID: <5406E686.3010803@freescale.com> (raw)
In-Reply-To: <20140816061655.d2fa481b47f701f2f2bd8552@freescale.com>
On 8/16/2014 2:16 PM, Kim Phillips wrote:
> On Thu, 14 Aug 2014 15:54:22 +0300
> Horia Geanta <horia.geanta@freescale.com> wrote:
>
>> This patch set adds Run Time Assembler (RTA) SEC descriptor library.
>> RTA is a replacement for incumbent "inline append".
>>
>> The library is intended to be a single code base for SEC descriptors creation
>> for all Freescale products. This comes with a series of advantages, such as
>> library being maintained / kept up-to-date with latest platforms, i.e. SEC
>> functionalities (for e.g. SEC incarnations present in Layerscape LS1 and LS2).
>>
>> RTA detects options in SEC descriptors that are not supported
>> by a SEC HW revision ("Era") and reports this back.
>> Say a descriptor uses Sequence Out Pointer (SOP) option for the SEQINPTR
>> command, which is supported starting from SEC Era 5. If the descriptor would
>> be built on a P4080R3 platform (which has SEC Era 4), RTA would report
>> "SEQ IN PTR: Flag(s) not supported by SEC Era 4".
>> This is extremely useful and saves a lot of time wasted on debugging.
>> SEC HW detects only *some* of these problems, leaving user wonder what causes
>> a "DECO Watchdog Timeout". And when it prints something more useful, sometimes
>> it does not point to the exact opcode.
>
> again, RTA just adds bloat to the kernel driver - the kernel driver
> is supposed to generate the appropriate descriptor for its target
> running SEC version no matter what, not "report back" what is/is not
> supported. This is a flaw at the RTA design level, as far as the
> kernel driver is concerned.
What is your understanding of developing a descriptor?
First it needs to be written, then tested - within the kernel driver.
Having no error checking in the code that generates descriptors
increases testing / debugging time significantly. Again, SEC HW provides
some error reporting, but in many cases this is a clueless Watchdog Timeout.
SEC descriptors development is complex enough to deserve a few
indications along the way.
Regards,
Horia
next prev parent reply other threads:[~2014-09-03 10:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 12:54 [PATCH v2 00/12] crypto: caam - Add RTA descriptor creation library Horia Geanta
2014-08-14 12:54 ` [PATCH v2 01/12] crypto: caam - completely remove error propagation handling Horia Geanta
2014-08-14 12:54 ` [PATCH v2 02/12] crypto: caam - desc.h fixes Horia Geanta
2014-08-14 12:54 ` [PATCH v2 03/12] crypto: caam - code cleanup Horia Geanta
2014-08-14 12:54 ` [PATCH v2 04/12] crypto: caam - move sec4_sg_entry to sg_sw_sec4.h Horia Geanta
2014-08-14 12:54 ` [PATCH v2 05/12] crypto: caam - add Run Time Library (RTA) - part 1 Horia Geanta
2014-08-14 12:54 ` [PATCH v2 06/12] crypto: caam - add Run Time Library (RTA) - part 2 Horia Geanta
2014-08-14 12:54 ` [PATCH v2 07/12] crypto: caam - add Run Time Library (RTA) - part 3 Horia Geanta
2014-08-14 12:54 ` [PATCH v2 08/12] crypto: caam - use RTA instead of inline append Horia Geanta
2014-08-14 12:54 ` [PATCH v2 09/12] crypto: caam - completely remove " Horia Geanta
2014-08-14 12:54 ` [PATCH v2 10/12] crypto: caam - refactor descriptor creation Horia Geanta
2014-08-14 12:54 ` [PATCH v2 11/12] crypto: caam - move caamalg shared descs in RTA library Horia Geanta
2014-08-14 12:54 ` [PATCH v2 12/12] crypto: caam - add Run Time Library (RTA) docbook Horia Geanta
2014-08-19 20:54 ` Randy Dunlap
2014-08-16 11:16 ` [PATCH v2 00/12] crypto: caam - Add RTA descriptor creation library Kim Phillips
2014-09-03 9:59 ` Horia Geantă [this message]
2014-09-03 23:54 ` Kim Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5406E686.3010803@freescale.com \
--to=horia.geanta@freescale.com \
--cc=alexandru.porosanu@freescale.com \
--cc=carmen.iorga@freescale.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kim.phillips@freescale.com \
--cc=linux-crypto@vger.kernel.org \
--cc=ruchika.gupta@freescale.com \
--cc=vakul@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).