From: Dmitry Kasatkin <d.kasatkin@samsung.com>
To: Herbert Xu <herbert@gondor.apana.org.au>, behanw@converseincode.com
Cc: agk@redhat.com, clm@fb.com, davem@davemloft.net,
dm-devel@redhat.com, fabf@skynet.be, jbacik@fb.com,
snitzer@redhat.com, tadeusz.struk@intel.com,
akpm@linux-foundation.org, bruce.w.allan@intel.com,
james.l.morris@oracle.com, john.griffin@intel.com,
linux-btrfs@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-ima-devel@lists.sourceforge.net,
linux-ima-user@lists.sourceforge.net,
linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
linux-security-module@vger.kernel.org, neilb@suse.de,
qat-linux@intel.com, serge@hallyn.com, thomas.lendacky@amd.com,
zohar@linux.vnet.ibm.com, torvalds@linux-foundation.org
Subject: Re: [PATCH v3 01/12] crypto: LLVMLinux: Add macro to remove use of VLAIS in crypto code
Date: Wed, 17 Sep 2014 14:15:40 +0300 [thread overview]
Message-ID: <54196D5C.6040104@samsung.com> (raw)
In-Reply-To: <20140917092212.GA1213@gondor.apana.org.au>
On 17/09/14 12:22, Herbert Xu wrote:
> On Mon, Sep 15, 2014 at 12:30:23AM -0700, behanw@converseincode.com wrote:
>> From: Behan Webster <behanw@converseincode.com>
>>
>> Add a macro which replaces the use of a Variable Length Array In Struct (VLAIS)
>> with a C99 compliant equivalent. This macro instead allocates the appropriate
>> amount of memory using an char array.
>>
>> The new code can be compiled with both gcc and clang.
>>
>> struct shash_desc contains a flexible array member member ctx declared with
>> CRYPTO_MINALIGN_ATTR, so sizeof(struct shash_desc) aligns the beginning
>> of the array declared after struct shash_desc with long long.
>>
>> No trailing padding is required because it is not a struct type that can
>> be used in an array.
>>
>> The CRYPTO_MINALIGN_ATTR is required so that desc is aligned with long long
>> as would be the case for a struct containing a member with
>> CRYPTO_MINALIGN_ATTR.
>>
>> Signed-off-by: Behan Webster <behanw@converseincode.com>
> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> Thanks,
Just in case.
I would still follow advice from "Michał Mirosław" to use shash##__desc[]
- Dmitry
next prev parent reply other threads:[~2014-09-17 11:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 7:30 [PATCH v3 00/12] LLVMLinux: Patches to enable the kernel to be compiled with clang/LLVM behanw
2014-09-15 7:30 ` [PATCH v3 01/12] crypto: LLVMLinux: Add macro to remove use of VLAIS in crypto code behanw
2014-09-15 8:06 ` [dm-devel] " Michał Mirosław
2014-09-15 8:37 ` Behan Webster
2014-09-17 9:22 ` Herbert Xu
2014-09-17 11:15 ` Dmitry Kasatkin [this message]
2014-09-17 11:30 ` Herbert Xu
2014-09-17 15:26 ` Behan Webster
2014-09-15 7:30 ` [PATCH v3 02/12] btrfs: LLVMLinux: Remove VLAIS behanw
2014-09-17 13:49 ` Chris Mason
2014-09-15 7:30 ` [PATCH v3 03/12] crypto: LLVMLinux: Remove VLAIS from crypto/ccp/ccp-crypto-sha.c behanw
2014-09-15 7:30 ` [PATCH v3 04/12] crypto: LLVMLinux: Remove VLAIS from crypto/mv_cesa.c behanw
2014-09-15 7:30 ` [PATCH v3 05/12] crypto: LLVMLinux: Remove VLAIS from crypto/n2_core.c behanw
2014-09-15 7:30 ` [PATCH v3 06/12] crypto: LLVMLinux: Remove VLAIS from crypto/omap_sham.c behanw
2014-09-15 7:30 ` [PATCH v3 07/12] crypto: LLVMLinux: Remove VLAIS from crypto/.../qat_algs.c behanw
2014-09-15 7:30 ` [PATCH v3 08/12] crypto, dm: LLVMLinux: Remove VLAIS usage from dm-crypt behanw
2014-09-15 7:30 ` [PATCH v3 09/12] crypto: LLVMLinux: Remove VLAIS usage from crypto/hmac.c behanw
2014-09-15 7:30 ` [PATCH v3 10/12] crypto: LLVMLinux: Remove VLAIS usage from libcrc32c.c behanw
2014-09-15 7:30 ` [PATCH v3 11/12] security, crypto: LLVMLinux: Remove VLAIS from ima_crypto.c behanw
2014-09-15 14:21 ` Linus Torvalds
2014-09-15 14:25 ` Behan Webster
2014-09-15 7:30 ` [PATCH v3 12/12] crypto: LLVMLinux: Remove VLAIS usage from crypto/testmgr.c behanw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54196D5C.6040104@samsung.com \
--to=d.kasatkin@samsung.com \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=behanw@converseincode.com \
--cc=bruce.w.allan@intel.com \
--cc=clm@fb.com \
--cc=davem@davemloft.net \
--cc=dm-devel@redhat.com \
--cc=fabf@skynet.be \
--cc=herbert@gondor.apana.org.au \
--cc=james.l.morris@oracle.com \
--cc=jbacik@fb.com \
--cc=john.griffin@intel.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-ima-devel@lists.sourceforge.net \
--cc=linux-ima-user@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=neilb@suse.de \
--cc=qat-linux@intel.com \
--cc=serge@hallyn.com \
--cc=snitzer@redhat.com \
--cc=tadeusz.struk@intel.com \
--cc=thomas.lendacky@amd.com \
--cc=torvalds@linux-foundation.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).