From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Prarit Bhargava <prarit@redhat.com>, linux-kernel@vger.kernel.org
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Bruce Allan <bruce.w.allan@intel.com>,
John Griffin <john.griffin@intel.com>,
qat-linux@intel.com, linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto, qat, use generic numa functions
Date: Wed, 08 Oct 2014 08:50:46 -0700 [thread overview]
Message-ID: <54355D56.8040908@intel.com> (raw)
In-Reply-To: <1412727129-14467-1-git-send-email-prarit@redhat.com>
Hi Prarit,
On 10/07/2014 05:12 PM, Prarit Bhargava wrote:
> The method in which the qat code determines the numa node for memory
> allocations is a bit clunky. On 2 socket, single node systems it is
> possible that adf_get_dev_node_id() returns node 1, even though node 1
> doesn't exist.
>
> This code transitions the qat code to the generic numa functions.
> Changing adf_get_dev_node_id() to a simple call to dev_get_node() results
> in a change to the adf_accel_dev struct as well.
The problem with that is we don't want to use any valid numa node, but
the node we are connected to or we don't want to use the accelerator at
all. Otherwise, when the first valid numa node happens to be the remote
node the dma transactions we be slow and instead of accelerating we will
slow things down.
A patch that enforces this is on it's way.
next prev parent reply other threads:[~2014-10-08 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 0:12 [PATCH] crypto, qat, use generic numa functions Prarit Bhargava
2014-10-08 15:50 ` Tadeusz Struk [this message]
2014-10-08 15:59 ` Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54355D56.8040908@intel.com \
--to=tadeusz.struk@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=john.griffin@intel.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=qat-linux@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).