From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] crypto: algif - Mark sgl end at the end of data
Date: Mon, 01 Dec 2014 06:53:41 -0800 [thread overview]
Message-ID: <547C80F5.6000006@intel.com> (raw)
In-Reply-To: <20141201144026.GA18008@gondor.apana.org.au>
Hi Herbert,
On 12/01/2014 06:40 AM, Herbert Xu wrote:
>> + nents = sg_nents(ctx->rsgl.sg);
>> > + sg_mark_end(&sg[nents - 1]);
> Huh? You're getting nents from the RX side and using it to mark
> the TX side? This makes no sense because RX may have no relationship
> whatsoever with TX.
Yes, but there shouldn't be more nents with data to be processed in TX
than nents in RX and in most cases they should be equal. Or am I missing
something?
Thanks,
Tadeusz
next prev parent reply other threads:[~2014-12-01 14:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 18:40 [PATCH] crypto: algif - Mark sgl end at the end of data Tadeusz Struk
2014-12-01 14:40 ` Herbert Xu
2014-12-01 14:53 ` Tadeusz Struk [this message]
2014-12-01 15:00 ` Herbert Xu
2014-12-01 15:03 ` Tadeusz Struk
2014-12-02 14:33 ` Herbert Xu
2014-12-02 15:06 ` Tadeusz Struk
-- strict thread matches above, loose matches on Subject: below --
2014-11-21 17:14 Tadeusz Struk
2014-11-25 14:42 ` Herbert Xu
2014-11-25 15:53 ` Tadeusz Struk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547C80F5.6000006@intel.com \
--to=tadeusz.struk@intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).