From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: qat-linux@intel.com, linux-crypto@vger.kernel.org,
"Jörn Engel" <joern@logfs.org>
Subject: Re: crypto: qat - Intel(R) QAT transport code
Date: Tue, 02 Dec 2014 08:49:09 -0800 [thread overview]
Message-ID: <547DED85.7080507@intel.com> (raw)
In-Reply-To: <20141202122140.GA15748@mwanda>
On 12/02/2014 04:21 AM, Dan Carpenter wrote:
> drivers/crypto/qat/qat_common/adf_transport.c
> 407 /* Enable IRQ coalescing always. This will allow to use
> 408 * the optimised flag and coalesc register.
> 409 * If it is disabled in the config file just use min time value */
> 410 if (adf_get_cfg_int(accel_dev, "Accelerator0",
> 411 ADF_ETRMGR_COALESCING_ENABLED_FORMAT,
> 412 bank_num, &coalesc_enabled) && coalesc_enabled)
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> This condition is reversed, so it only enables coalescing on error.
Hello Dan,
Yes, you are correct. Looks like we never enable interrupt coalescing.
Thanks for reporting the issue. Patch fixing this will be out soon.
Regards,
Tadeusz
next prev parent reply other threads:[~2014-12-02 16:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 12:21 crypto: qat - Intel(R) QAT transport code Dan Carpenter
2014-12-02 16:49 ` Tadeusz Struk [this message]
2014-12-02 19:01 ` Tadeusz Struk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547DED85.7080507@intel.com \
--to=tadeusz.struk@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=joern@logfs.org \
--cc=linux-crypto@vger.kernel.org \
--cc=qat-linux@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).