From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Cc: qat-linux <qat-linux@intel.com>
Subject: Re: crypto: qat - Fix incorrect uses of memzero_explicit
Date: Mon, 05 Jan 2015 09:49:05 -0800 [thread overview]
Message-ID: <54AACE91.7070904@intel.com> (raw)
In-Reply-To: <20150105054813.GA23110@gondor.apana.org.au>
On 01/04/2015 09:48 PM, Herbert Xu wrote:
> memzero_explicit should only be used on stack variables that get
> zapped just before they go out of scope.
>
> This patch replaces all unnecessary uses of memzero_explicit with
> memset, removes two memzero_explicit calls altogether as the tfm
> context comes pre-zeroed, and adds a missing memzero_explicit of
> the stack variable buff in qat_alg_do_precomputes. The memzeros
> on ipad/opad + digest_size/auth_keylen are also removed as the
> entire auth_state is already zeroed on entry.
Hi Herbert,
Except the bad indentation in lines 1176 & 1183 :) this looks ok to me.
Thanks.
Acked-by: Tadeusz Struk <tadeusz.struk@intel.com>
next prev parent reply other threads:[~2015-01-05 17:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 5:48 crypto: qat - Fix incorrect uses of memzero_explicit Herbert Xu
2015-01-05 17:49 ` Tadeusz Struk [this message]
2015-01-05 20:54 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AACE91.7070904@intel.com \
--to=tadeusz.struk@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=qat-linux@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox