From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, qat-linux@intel.com
Subject: Re: crypto: qat - Ensure ipad and opad are zeroed
Date: Tue, 13 Jan 2015 15:20:51 -0800 [thread overview]
Message-ID: <54B5A853.3030304@intel.com> (raw)
In-Reply-To: <20150113230703.GA12608@gondor.apana.org.au>
On 01/13/2015 03:07 PM, Herbert Xu wrote:
> The patch ad511e260a27b8e35d273cc0ecfe5a8ff9543181 (crypto: qat -
> Fix incorrect uses of memzero_explicit) broke hashing because the
> code was in fact overwriting the qat_auth_state variable.
>
> In fact there is no reason for the variable to exist anyway since
> all we are using it for is to store ipad and opad. So we could
> simply create ipad and opad directly and avoid this whole mess.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Ok that looks better. Thanks. I think we should also remove the
definition of struct qat_auth_state in line 107 and the #def above.
Regards,
Tadeusz
prev parent reply other threads:[~2015-01-13 23:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 20:27 [PATCH] crypto: qat - Fix for qat_aes_cbc_hmac_sha512 Tadeusz Struk
2015-01-13 21:25 ` Herbert Xu
2015-01-13 22:21 ` Tadeusz Struk
2015-01-13 22:47 ` Herbert Xu
2015-01-13 22:55 ` Tadeusz Struk
2015-01-13 23:07 ` crypto: qat - Ensure ipad and opad are zeroed Herbert Xu
2015-01-13 23:20 ` Tadeusz Struk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B5A853.3030304@intel.com \
--to=tadeusz.struk@intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=qat-linux@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).