From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Stephan Mueller <smueller@chronox.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>, linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: aesni - make driver-gcm-aes-aesni helper a proper aead alg
Date: Mon, 26 Jan 2015 12:38:46 -0800 [thread overview]
Message-ID: <54C6A5D6.1080909@intel.com> (raw)
In-Reply-To: <6186402.WdfiYaY5GD@tachyon.chronox.de>
On 01/26/2015 11:20 AM, Stephan Mueller wrote:
>> > Here we have two instances of crypto_aead algorithm, one the
>> > rfc4106(gcm(aes)), whose setkey points to rfc4106_set_key(), and the
>> > internal helper __gcm-aes-aesni (wrapped in by the cryptd interface),
>> > whose setkey points to common_rfc4106_set_key(). If we would call
>> > crypto_aead_setkey() on the parent from rfc4106_set_key() then we would
>> > invoke the same rfc4106_set_key() function. It would be ok to call the
>> > crypto_aead_setkey() on the child, but what's the point?
> The point is to maintain an onion style framework that is coherent. All other
> ciphers implement it (look at the generic gcm.c).
>
Hi Stephan,
Ok, to keep it consistent is a good enough reason. I'll send v2 soon.
Thanks,
Tadeusz
next prev parent reply other threads:[~2015-01-26 20:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 22:33 [PATCH] crypto: aesni - make driver-gcm-aes-aesni helper a proper aead alg Tadeusz Struk
2015-01-25 8:58 ` Stephan Mueller
2015-01-25 16:26 ` Tadeusz Struk
2015-01-26 0:10 ` Herbert Xu
2015-01-26 16:58 ` Tadeusz Struk
2015-01-26 19:20 ` Stephan Mueller
2015-01-26 20:38 ` Tadeusz Struk [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-02-06 18:25 Tadeusz Struk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C6A5D6.1080909@intel.com \
--to=tadeusz.struk@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).