From: Daniel Borkmann <daniel@iogearbox.net>
To: Herbert Xu <herbert@gondor.apana.org.au>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: crypto: fips - Move fips_enabled sysctl into fips.c
Date: Thu, 23 Apr 2015 09:36:46 +0200 [thread overview]
Message-ID: <5538A10E.1090307@iogearbox.net> (raw)
In-Reply-To: <20150422050222.GA7414@gondor.apana.org.au>
On 04/22/2015 07:02 AM, Herbert Xu wrote:
> There is currently a large ifdef FIPS code section in proc.c.
> Ostensibly it's there because the fips_enabled sysctl sits under
> /proc/sys/crypto. However, no other crypto sysctls exist.
>
> In fact, the whole ethos of the crypto API is against such user
> interfaces so this patch moves all the FIPS sysctl code over to
> fips.c.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
...
>
> int fips_enabled;
> EXPORT_SYMBOL_GPL(fips_enabled);
While you're at it, this should also be marked as __read_mostly.
Thanks,
Daniel
prev parent reply other threads:[~2015-04-23 7:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 5:02 crypto: fips - Move fips_enabled sysctl into fips.c Herbert Xu
2015-04-22 12:33 ` Stephan Mueller
2015-04-23 1:02 ` Herbert Xu
2015-04-23 7:36 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5538A10E.1090307@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).