From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE9FF3AE713 for ; Fri, 29 May 2026 07:05:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780038337; cv=none; b=IkOwU3hHnDztyaBUfmtTw2Jt7bnyD5fsEPpasg6NHElmOXtqCoNvCvcPncogHnteMc8KO5Wjs7pcrC1O6sgCZt/8vGfpYaz/2T5prNPpgwgbU6R5iudvVEZfzSmZTpinSVz/V74O5GcvzVzY0mZgp4IeBhq7aPlUBspwcIVlwLM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780038337; c=relaxed/simple; bh=yS1XlYDjTMgxwgN2DZGzDYeL5SarwMcWqXtVsPpG4iU=; h=MIME-Version:Date:Content-Type:From:Message-ID:Subject:To:Cc: In-Reply-To:References; b=qlHkB9Drdb7+7lRuLsdzSpqr7fYncwQpT3xqj76QYNoZiyVXgdgnC2rTjKrEfcpAFHY/LmxFq7NFHHW6GWC3LTxpyJRY8z2A++IoFvCxcFwXzlbFRnKkS0IVUU0mEVBRiByGwzmw14Z0OK79WD2MNCNSx82crp8MmPFzaKh8zmA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=XnwYGh/o; arc=none smtp.client-ip=95.215.58.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="XnwYGh/o" Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1780038331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L1/AzmjwYbvz5ac6FUFa2AXbd/guUDNm7WSGUACd+fE=; b=XnwYGh/o1rfZsynwCJXEx2rjmGjHm/owl7jHyuy0Vc0OrpofbU7dzYUkbSlAaUFJjPR4/p xQPqAlKZN1UOhyKM3lEBNMxrtajO6d7x/ot20UyfuhDIhBX6uwlSjN5ReQvSMwk4DDxicw KOVYDCuWjg7i/lyFRKx5guKlq+7jKBU= Date: Fri, 29 May 2026 07:05:24 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Tianchu Chen" Message-ID: <554bc5c03d16e7a76db35be4a1c0d23cda2d4df6@linux.dev> TLS-Required: No Subject: Re: [PATCH] crypto: sun4i-ss: restrict PRNG seed length to prevent heap overflow To: "Herbert Xu" Cc: clabbe.montjoie@gmail.com, davem@davemloft.net, wens@kernel.org, jernej.skrabec@gmail.com, samuel@sholland.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org In-Reply-To: References: X-Migadu-Flow: FLOW_OUT May 29, 2026 at 2:11 PM, "Herbert Xu" wrote: >=20 >=20On Thu, May 28, 2026 at 02:53:17PM +0000, Tianchu Chen wrote: >=20 >=20>=20 >=20> diff --git a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-prng.c b/dr= ivers/crypto/allwinner/sun4i-ss/sun4i-ss-prng.c > > index 491fcb7b8..010fa891c 100644 > > --- a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-prng.c > > +++ b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-prng.c > > @@ -8,6 +8,8 @@ int sun4i_ss_prng_seed(struct crypto_rng *tfm, const= u8 *seed, > > struct rng_alg *alg =3D crypto_rng_alg(tfm); > >=20=20 >=20> algt =3D container_of(alg, struct sun4i_ss_alg_template, alg.rng); > > + if (slen > sizeof(algt->ss->seed)) > > + return -EINVAL; > >=20 >=20This should simply ignore the extra data instead of failing. Thanks for pointing out, silent truncation is more appropriate here.=20 I'll=20send a v2 patch with min_t soon. Best regards, Tianchu Chen