Re: [PATCH v3 14/16] ARM: marvell/dt: enable crypto on armada-xp-gp

[Gregory CLEMENT <gregory.clement@free-electrons.com>]

On 26/05/2015 10:59, Boris Brezillon wrote:
> On Mon, 25 May 2015 17:10:37 +0200
> Gregory CLEMENT <gregory.clement@free-electrons.com> wrote:
> 
>> Hi Boris,
>>
>> On 22/05/2015 15:34, Boris Brezillon wrote:
>>> Enable the crypto IP on armada-xp-gp.
>>>
>>> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>>> ---
>>>  arch/arm/boot/dts/armada-xp-gp.dts | 4 +++-
>>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/armada-xp-gp.dts b/arch/arm/boot/dts/armada-xp-gp.dts
>>> index 565227e..8a739f4 100644
>>> --- a/arch/arm/boot/dts/armada-xp-gp.dts
>>> +++ b/arch/arm/boot/dts/armada-xp-gp.dts
>>> @@ -94,7 +94,9 @@
>>>  	soc {
>>>  		ranges = <MBUS_ID(0xf0, 0x01) 0 0 0xf1000000 0x100000
>>>  			  MBUS_ID(0x01, 0x1d) 0 0 0xfff00000 0x100000
>>> -			  MBUS_ID(0x01, 0x2f) 0 0 0xf0000000 0x1000000>;
>>> +			  MBUS_ID(0x01, 0x2f) 0 0 0xf0000000 0x1000000
>>> +			  MBUS_ID(0x09, 0x09) 0 0 0xf1100000 0x10000
>>> +			  MBUS_ID(0x09, 0x05) 0 0 0xf1110000 0x10000>;
>>
>> As the crypto engine really depend on the SoC itself and not of the board,
>> what about updating the dts of the other board using an Armada XP?
> 
> But that means introducing changes I haven't tested. Are you okay with
> that ?

Maybe I missed something but as the crypto is fully integrated in the SoC,
if for a given SoC it works on a board it would work on all the boards using
the same SoC.

The board specific part seems about setting memory address on the mbus.

By the way could you add a comment in front of the new line ? so next time
someone will copy and past one of the dts file, he will understand the
signification of these two lines.

But is it really depending of the board itself?
I see that the first lines are the same on all the dts, I just remember that
there was a reason why we could not put it in the dtsi. My point here, is as
the configuration is the same on all the boards, adding the crypto on all the
board should work without any issue.


Thanks,

Gregory





> 
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com