From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-kernel@vger.kernel.org, keescook@chromium.org,
jwboyer@redhat.com, smueller@chronox.de, richard@nod.at,
steved@redhat.com, qat-linux@intel.com, dhowells@redhat.com,
linux-crypto@vger.kernel.org, james.l.morris@oracle.com,
jkosina@suse.cz, zohar@linux.vnet.ibm.com, davem@davemloft.net,
vgoyal@redhat.com
Subject: Re: [PATCH RFC v5 2/4] crypto: add PKE API
Date: Mon, 15 Jun 2015 21:48:22 -0700 [thread overview]
Message-ID: <557FAA96.2030008@intel.com> (raw)
In-Reply-To: <20150616040605.GA20597@gondor.apana.org.au>
On 06/15/2015 09:06 PM, Herbert Xu wrote:
>> No, it will handle whatever it will find. So if a public key will be passed it will only set "n" and "e".
>> > If a private key will be passed it will set all three "n", "e", and "d".
>> > Then during operation I check if there is everything that's required.
> AFAICS the ASN1 parser will call all three functions and bomb out
> if any one of them fails. If you did make them all optional then
> you'd need to check to ensure that at least n and e are present.
>
> Also all your test vectors contain private keys. Please add at
> least one that contains a public key only to test this.
I've just tested it and it works fine for both private and public keys.
I'll add one vector to test only public key case.
Thanks
next prev parent reply other threads:[~2015-06-16 4:48 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 20:18 [PATCH RFC v5 0/4] crypto: Introduce Public Key Encryption API Tadeusz Struk
2015-06-15 20:18 ` [PATCH RFC v5 1/4] MPILIB: add mpi_read_buf() and mpi_get_size() helpers Tadeusz Struk
2015-06-16 6:40 ` Herbert Xu
2015-06-15 20:18 ` [PATCH RFC v5 2/4] crypto: add PKE API Tadeusz Struk
2015-06-15 23:46 ` Herbert Xu
2015-06-15 23:49 ` Herbert Xu
2015-06-15 23:50 ` Herbert Xu
2015-06-15 23:54 ` Herbert Xu
2015-06-15 23:59 ` Herbert Xu
2015-06-16 2:21 ` Tadeusz Struk
2015-06-16 2:29 ` Herbert Xu
2015-06-16 2:46 ` Tadeusz Struk
2015-06-16 2:50 ` Herbert Xu
2015-06-16 2:55 ` Tadeusz Struk
2015-06-16 0:05 ` Herbert Xu
2015-06-16 2:03 ` Tadeusz Struk
2015-06-16 2:27 ` Herbert Xu
2015-06-16 2:41 ` Tadeusz Struk
2015-06-16 3:25 ` Herbert Xu
2015-06-16 3:36 ` Tadeusz Struk
2015-06-16 4:06 ` Herbert Xu
2015-06-16 4:48 ` Tadeusz Struk [this message]
2015-06-16 2:29 ` Tadeusz Struk
2015-06-16 2:32 ` Herbert Xu
2015-06-15 20:18 ` [PATCH RFC v5 3/4] crypto: rsa: add a new rsa generic implementation Tadeusz Struk
2015-06-15 23:23 ` Stephan Mueller
2015-06-16 1:49 ` Tadeusz Struk
2015-06-16 2:19 ` Stephan Mueller
2015-06-16 2:26 ` Tadeusz Struk
2015-06-15 20:18 ` [PATCH RFC v5 4/4] crypto: add tests vectors for RSA Tadeusz Struk
2015-06-16 0:37 ` Herbert Xu
2015-06-16 6:26 ` Tadeusz Struk
2015-06-16 6:28 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557FAA96.2030008@intel.com \
--to=tadeusz.struk@intel.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=james.l.morris@oracle.com \
--cc=jkosina@suse.cz \
--cc=jwboyer@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qat-linux@intel.com \
--cc=richard@nod.at \
--cc=smueller@chronox.de \
--cc=steved@redhat.com \
--cc=vgoyal@redhat.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).