linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH 6/8] crypto: qat - Convert to new AEAD interface
Date: Fri, 31 Jul 2015 13:39:59 -0700	[thread overview]
Message-ID: <55BBDD1F.4020208@intel.com> (raw)
In-Reply-To: <E1ZKkWe-0004C6-SN@gondolin.me.apana.org.au>

On 07/30/2015 02:53 AM, Herbert Xu wrote:
> -}, {
> +	.init = qat_alg_aead_sha512_init,
> +	.exit = qat_alg_aead_exit,
> +	.setkey = qat_alg_aead_setkey,
> +	.decrypt = qat_alg_aead_dec,
> +	.encrypt = qat_alg_aead_enc,
> +	.ivsize = AES_BLOCK_SIZE,
> +	.maxauthsize = SHA512_DIGEST_SIZE,

Hi Herbert,
crypto_aead_encrypt() and crypto_aead_decrypt() work fine, but crypto_aead_givencrypt(),
which is still supported on the API causes a crash. Should we also disable all the
crypto_aead_giv* calls? I use it in my internal tests.

Other that that looks ok:
Tested-by: Tadeusz Struk <tadeusz.struk@intel.com>

  reply	other threads:[~2015-07-31 20:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-30  9:41 [PATCH 0/8] crypto: aed - Convert authenc to new interface Herbert Xu
2015-07-30  9:53 ` [PATCH 1/8] crypto: testmgr - Disable authenc test and convert test vectors Herbert Xu
2015-07-30  9:53 ` [PATCH 2/8] crypto: authenc - Convert to new AEAD interface Herbert Xu
2015-07-30  9:53 ` [PATCH 3/8] crypto: caam - Convert authenc " Herbert Xu
2015-07-30  9:53 ` [PATCH 4/8] crypto: ixp4xx - Convert " Herbert Xu
2015-07-30  9:53 ` [PATCH 5/8] crypto: picoxcell " Herbert Xu
2015-07-30  9:53 ` [PATCH 6/8] crypto: qat " Herbert Xu
2015-07-31 20:39   ` Tadeusz Struk [this message]
2015-08-02  1:23     ` Herbert Xu
2015-08-03 17:01       ` Tadeusz Struk
2015-08-04  9:59         ` Herbert Xu
2015-08-04 12:47           ` Herbert Xu
2015-08-04 13:28             ` Tadeusz Struk
2015-08-04 13:26           ` Tadeusz Struk
2015-08-04 13:32             ` Herbert Xu
2015-08-04 13:42               ` Tadeusz Struk
2015-08-04 13:44                 ` Herbert Xu
2015-08-04 13:50                   ` Tadeusz Struk
2015-07-30  9:53 ` [PATCH 7/8] crypto: talitos " Herbert Xu
2015-07-30  9:53 ` [PATCH 8/8] crypto: testmgr - Reenable authenc tests Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55BBDD1F.4020208@intel.com \
    --to=tadeusz.struk@intel.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).