From: "Horia Geantă" <horia.geanta@freescale.com>
To: Fabio Estevam <festevam@gmail.com>, <herbert@gondor.apana.org.au>
Cc: <vicki.milhoan@freescale.com>, <linux-crypto@vger.kernel.org>,
"Fabio Estevam" <fabio.estevam@freescale.com>
Subject: Re: [PATCH 4/4] crypto: caam: ctrl: Use devm_kcalloc()
Date: Fri, 21 Aug 2015 18:42:53 +0300 [thread overview]
Message-ID: <55D746FD.8090200@freescale.com> (raw)
In-Reply-To: <1440168570-13635-4-git-send-email-festevam@gmail.com>
On 8/21/2015 5:49 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
>>From Documentation/CodingStyle:
>
> "The preferred form for allocating a zeroed array is the following:
>
> p = kcalloc(n, sizeof(...), ...); "
>
> , so do as suggested.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
While here, you could also address the following:
drivers/crypto/caam/caamalg.c:4317
drivers/crypto/caam/caamhash.c:1844
drivers/crypto/caam/caamrng.c:354
drivers/crypto/caam/jr.c:413
drivers/crypto/caam/jr.c:418
drivers/crypto/caam/jr.c:423
drivers/crypto/caam/jr.c:482
(and any other place that I might've missed).
Since related, I guess the changes (3/4, 4/4 and above) could live in a
single patch.
Thanks,
Horia
prev parent reply other threads:[~2015-08-21 15:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 14:49 [PATCH 1/4] crypto: caam: ctrl: Fix the error handling Fabio Estevam
2015-08-21 14:49 ` [PATCH 2/4] crypto: caam: ctrl: Propagate the real error code Fabio Estevam
2015-08-21 14:49 ` [PATCH 3/4] crypto: caam: ctrl: Use the preferred method for devm_kzalloc() Fabio Estevam
2015-08-21 14:49 ` [PATCH 4/4] crypto: caam: ctrl: Use devm_kcalloc() Fabio Estevam
2015-08-21 15:42 ` Horia Geantă [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D746FD.8090200@freescale.com \
--to=horia.geanta@freescale.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=vicki.milhoan@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).