From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Stephan Mueller <smueller@chronox.de>
Cc: herbert@gondor.apana.org.au, keescook@chromium.org,
jwboyer@redhat.com, richard@nod.at, steved@redhat.com,
linux-kernel@vger.kernel.org, dhowells@redhat.com,
linux-crypto@vger.kernel.org, james.l.morris@oracle.com,
jkosina@suse.cz, zohar@linux.vnet.ibm.com, davem@davemloft.net,
vgoyal@redhat.com
Subject: Re: [PATCH 1/2] crypto: KEYS: convert public key to the akcipher API
Date: Mon, 24 Aug 2015 10:45:05 -0700 [thread overview]
Message-ID: <55DB5821.50807@intel.com> (raw)
In-Reply-To: <3295616.oBrs36mNlq@tauon.atsec.com>
Hi Stephan,
On 08/15/2015 11:08 AM, Stephan Mueller wrote:
> Am Mittwoch, 12. August 2015, 20:54:39 schrieb Tadeusz Struk:
>
> Hi Tadeusz,
>
>> @@ -41,7 +41,7 @@ struct pkcs7_parse_context {
>> static void pkcs7_free_signed_info(struct pkcs7_signed_info *sinfo)
>> {
>> if (sinfo) {
>> - mpi_free(sinfo->sig.mpi[0]);
>> + kfree(sinfo->sig.s);
>
> kzfree?
>
>> kfree(sinfo->sig.digest);
>
> kzfree?
>
>> kfree(sinfo->signing_cert_id);
>> kfree(sinfo);
>
> kzfree (due to ->msdigest)?
>
Sorry for late response. I was on vacation.
All these above are module signatures, which are not sensitive,
so no need to zero the buffers on free.
The only thing that is sensitive is the private key,
which is only used for signing modules on make modules_install
and never included in the kernel.
Thanks,
T
next prev parent reply other threads:[~2015-08-24 17:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 3:54 [PATCH 0/2] crypto: KEYS: convert public key to the akcipher API Tadeusz Struk
2015-08-13 3:54 ` [PATCH 1/2] " Tadeusz Struk
2015-08-13 14:23 ` David Howells
2015-08-13 16:47 ` Tadeusz Struk
2015-08-14 1:09 ` Herbert Xu
2015-08-15 18:08 ` Stephan Mueller
2015-08-24 17:45 ` Tadeusz Struk [this message]
2015-08-13 3:54 ` [PATCH 2/2] crypto: qat - Don't move data inside output buffer Tadeusz Struk
2015-08-13 16:40 ` Tadeusz Struk
2015-08-14 5:14 ` Herbert Xu
2015-08-14 6:14 ` Tadeusz Struk
2015-08-14 6:26 ` Herbert Xu
2015-08-14 14:21 ` Tadeusz Struk
2015-08-17 8:48 ` Herbert Xu
2015-08-14 14:24 ` Tadeusz Struk
2015-08-17 8:50 ` Herbert Xu
2015-08-18 1:05 ` Tadeusz Struk
2015-08-18 2:39 ` Herbert Xu
2015-08-13 13:56 ` [PATCH 0/2] crypto: KEYS: convert public key to the akcipher API David Howells
2015-08-13 16:44 ` Tadeusz Struk
-- strict thread matches above, loose matches on Subject: below --
2015-12-09 23:52 [PATCH 0/2] crypto: KEYS: convert public key to akcipher api Tadeusz Struk
2015-12-09 23:52 ` [PATCH 1/2] crypto: KEYS: convert public key to the " Tadeusz Struk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DB5821.50807@intel.com \
--to=tadeusz.struk@intel.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=james.l.morris@oracle.com \
--cc=jkosina@suse.cz \
--cc=jwboyer@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
--cc=smueller@chronox.de \
--cc=steved@redhat.com \
--cc=vgoyal@redhat.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).