Re: [PATCH] crypto: Fix ASN.1 key handling for RSA akcipher

[Tadeusz Struk <tadeusz.struk@intel.com>]

Hi Marcel,
On 08/27/2015 10:28 PM, Marcel Holtmann wrote:
> +++ b/crypto/rsaprivatekey.asn1
> @@ -0,0 +1,13 @@
> +RSAPrivateKey ::= SEQUENCE {
> +	version		Version,
> +	modulus		INTEGER ({ rsa_get_n }),	-- n
> +	publicExponent	INTEGER ({ rsa_get_e }),	-- e
> +	privateExponent	INTEGER ({ rsa_get_d }),	-- d
> +	prime1		INTEGER,			-- p
> +	prime2		INTEGER,			-- q
> +	exponent1	INTEGER,			-- d mod (p-1)
> +	exponent2	INTEGER,			-- d mod (q-1)
> +	coefficient	INTEGER				-- (inverse of q) mod p
> +}
> +
> +Version ::= INTEGER

If you want to do this you should also update the existing RSA test vectors, because
they are failing after this patch is applied.
The reason is that there is no version in the private keys in crypto/testmgr.h
And the QAT RSA implementation should also be updated so they are consistent.

I have already started to do the changes proposed for the akcipher api to add SGLs
support and to split the set_key for set_publickey and set_privatekey so I will
take care of this.
Thanks,
T