From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Stephan Mueller <smueller@chronox.de>
Cc: herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org,
qat-linux@intel.com
Subject: Re: [PATCH 6/8] crypto: rsa - update accoring to akcipher API changes
Date: Wed, 9 Sep 2015 11:03:54 -0700 [thread overview]
Message-ID: <55F0748A.4070609@intel.com> (raw)
In-Reply-To: <1717447.bQZjD6cfWn@tauon.atsec.com>
On 09/09/2015 09:35 AM, Stephan Mueller wrote:
>> + if (sg_is_last(req->dst)) {
>> >+ ret = mpi_read_buffer(c, sg_virt(req->dst), dst_len,
>> >+ &req->out_len, &sign);
>> >+ } else {
>> >+ void *ptr = kmalloc(dst_len, GFP_KERNEL);
>> >+
>> >+ if (!ptr)
>> >+ goto err_free_m;
>> >+
>> >+ ret = mpi_read_buffer(c, ptr, dst_len, &req->out_len, &sign);
>> >+ scatterwalk_map_and_copy(ptr, req->dst, 0, dst_len, 1);
>> >+ kfree(ptr);
> Just a question: this code is present 4 times, can that be put into a separate
> inline?
>
I have put it like this because it is easier to read.
All 4 functions use different variable names according to the spec.
next prev parent reply other threads:[~2015-09-09 18:09 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 16:14 [PATCH 0/8] crypto: Updates to akcipher API Tadeusz Struk
2015-09-09 16:15 ` [PATCH 1/8] crypto: akcipher - return status from crypto_unregister_alg Tadeusz Struk
2015-09-18 11:29 ` Herbert Xu
2015-09-09 16:15 ` [PATCH 2/8] crypto: rsa - check status returned from crypto_unregister_akcipher Tadeusz Struk
2015-09-09 16:15 ` [PATCH 3/8] crypto: qat " Tadeusz Struk
2015-09-09 16:15 ` [PATCH 4/8] crypto: akcipher - Changes to asymmetric key API Tadeusz Struk
2015-09-09 16:25 ` Stephan Mueller
2015-09-09 16:29 ` Tadeusz Struk
2015-09-09 16:41 ` Stephan Mueller
2015-09-09 16:44 ` Tadeusz Struk
2015-09-09 18:53 ` Andrzej Zaborowski
2015-09-09 19:13 ` Stephan Mueller
2015-09-09 19:35 ` Tadeusz Struk
2015-09-18 11:35 ` Herbert Xu
2015-09-09 16:15 ` [PATCH 5/8] lib/scatterlist: Add sg_len helper Tadeusz Struk
2015-09-09 16:27 ` Stephan Mueller
2015-09-09 16:31 ` Tadeusz Struk
2015-09-09 16:39 ` Stephan Mueller
2015-09-09 16:46 ` Tadeusz Struk
2015-09-09 16:49 ` Stephan Mueller
2015-09-09 16:51 ` Tadeusz Struk
2015-09-09 16:56 ` Stephan Mueller
2015-09-09 17:02 ` Tadeusz Struk
2015-09-09 17:05 ` Stephan Mueller
2015-09-09 17:16 ` Tadeusz Struk
2015-09-09 17:37 ` Stephan Mueller
2015-09-09 16:54 ` Stephan Mueller
2015-09-09 16:15 ` [PATCH 6/8] crypto: rsa - update accoring to akcipher API changes Tadeusz Struk
2015-09-09 16:35 ` Stephan Mueller
2015-09-09 18:03 ` Tadeusz Struk [this message]
2015-09-09 16:15 ` [PATCH 7/8] crypto: qat " Tadeusz Struk
2015-09-09 16:15 ` [PATCH 8/8] crypto: testmgr - update test mgr according to " Tadeusz Struk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F0748A.4070609@intel.com \
--to=tadeusz.struk@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=qat-linux@intel.com \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).