From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
David Howells <dhowells@redhat.com>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH] MPI: Fix mpi_read_buffer
Date: Tue, 15 Sep 2015 08:56:09 -0700 [thread overview]
Message-ID: <55F83F99.60904@intel.com> (raw)
In-Reply-To: <20150915122424.GA3743@gondor.apana.org.au>
On 09/15/2015 05:24 AM, Herbert Xu wrote:
>>> Change mpi_read_buffer to return a number without leading zeros
>>> > > so that mpi_read_buffer and mpi_get_buffer return the same thing.
>> >
>> > Hmmm... This would appear to have the undesirable side effect of causing 1
>> > out of 256 module signing keys to be unusable (ie. those that begin with 00).
> I thought Tadeusz was just restoring the original behaviour, no?
That was the intention.
David, I can ran some more test if you have the key that was failing and
be willing to share it.
prev parent reply other threads:[~2015-09-15 15:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 14:52 [PATCH] MPI: Fix mpi_read_buffer Tadeusz Struk
2015-08-25 13:17 ` Herbert Xu
2015-09-15 9:09 ` David Howells
2015-09-15 11:05 ` David Howells
2015-09-15 12:24 ` Herbert Xu
2015-09-15 15:56 ` Tadeusz Struk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F83F99.60904@intel.com \
--to=tadeusz.struk@intel.com \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).