From: "Horia Geantă" <horia.geanta@freescale.com>
To: Fabio Estevam <festevam@gmail.com>, <herbert@gondor.apana.org.au>
Cc: <vicki.milhoan@freescale.com>, <linux-crypto@vger.kernel.org>,
"Fabio Estevam" <fabio.estevam@freescale.com>
Subject: Re: [PATCH] caam: desc: Remove unused JUMP_TYPE_MASK definition
Date: Tue, 15 Sep 2015 19:42:37 +0300 [thread overview]
Message-ID: <55F84A7D.1070002@freescale.com> (raw)
In-Reply-To: <1441304489-21738-1-git-send-email-festevam@gmail.com>
On 9/3/2015 9:21 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> JUMP_TYPE_MASK is defined in desc.h and it is never used, so we can
> safely remove it to avoid the following build warning:
>
> In file included from drivers/crypto/caam/desc_constr.h:7:0,
> from drivers/crypto/caam/ctrl.c:15:
> drivers/crypto/caam/desc.h:1495:0: warning: "JUMP_TYPE_MASK" redefined
> #define JUMP_TYPE_MASK (0x03 << JUMP_TYPE_SHIFT)
> ^
> In file included from include/linux/module.h:19:0,
> from drivers/crypto/caam/compat.h:9,
> from drivers/crypto/caam/ctrl.c:11:
> include/linux/jump_label.h:131:0: note: this is the location of the previous definition
> #define JUMP_TYPE_MASK 1UL
>
> Reported-by: Olof's autobuilder <build@lixom.net>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
The build warning is introduced by commit
a1efb01feca5 ("jump_label, locking/static_keys: Rename JUMP_LABEL_TYPE_*
and related helpers to the static_key* pattern")
which currently is not in cryptodev-2.6 tree, i.e. can only be found
upstream.
Other than this,
Reviewed-by: Horia Geantă <horia.geanta@freescale.com>
Horia
prev parent reply other threads:[~2015-09-15 16:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 18:21 [PATCH] caam: desc: Remove unused JUMP_TYPE_MASK definition Fabio Estevam
2015-09-15 16:42 ` Horia Geantă [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F84A7D.1070002@freescale.com \
--to=horia.geanta@freescale.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=vicki.milhoan@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).