linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] crypto: qat - VF should never trigger SBR on PH
@ 2015-09-18 15:59 Tadeusz Struk
  2015-09-18 16:01 ` Tadeusz Struk
  2015-09-21 15:04 ` Herbert Xu
  0 siblings, 2 replies; 4+ messages in thread
From: Tadeusz Struk @ 2015-09-18 15:59 UTC (permalink / raw)
  To: herbert; +Cc: linux-crypto, qat-linux, conor.mcloughlin, tadeusz.struk

From: Conor McLoughlin <conor.mcloughlin@intel.com>

Don't allow to trigger SBR from a VF running in VMM context.

Signed-off-by: Conor McLoughlin <conor.mcloughlin@intel.com>
Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
---
 drivers/crypto/qat/qat_common/adf_aer.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/crypto/qat/qat_common/adf_aer.c b/drivers/crypto/qat/qat_common/adf_aer.c
index a57b419..0a5ca0b 100644
--- a/drivers/crypto/qat/qat_common/adf_aer.c
+++ b/drivers/crypto/qat/qat_common/adf_aer.c
@@ -88,6 +88,9 @@ static void adf_dev_restore(struct adf_accel_dev *accel_dev)
 	struct pci_dev *parent = pdev->bus->self;
 	uint16_t bridge_ctl = 0;
 
+	if (accel_dev->is_vf)
+		return;
+
 	dev_info(&GET_DEV(accel_dev), "Resetting device qat_dev%d\n",
 		 accel_dev->accel_id);
 

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] crypto: qat - VF should never trigger SBR on PH
  2015-09-18 15:59 [PATCH] crypto: qat - VF should never trigger SBR on PH Tadeusz Struk
@ 2015-09-18 16:01 ` Tadeusz Struk
  2015-09-21 15:04 ` Herbert Xu
  1 sibling, 0 replies; 4+ messages in thread
From: Tadeusz Struk @ 2015-09-18 16:01 UTC (permalink / raw)
  To: herbert; +Cc: linux-crypto, qat-linux, conor.mcloughlin

Hi Herbert,
On 09/18/2015 08:59 AM, Tadeusz Struk wrote:
> From: Conor McLoughlin <conor.mcloughlin@intel.com>
> 
> Don't allow to trigger SBR from a VF running in VMM context.
> 
> Signed-off-by: Conor McLoughlin <conor.mcloughlin@intel.com>
> Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
> ---
>  drivers/crypto/qat/qat_common/adf_aer.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/crypto/qat/qat_common/adf_aer.c b/drivers/crypto/qat/qat_common/adf_aer.c
> index a57b419..0a5ca0b 100644
> --- a/drivers/crypto/qat/qat_common/adf_aer.c
> +++ b/drivers/crypto/qat/qat_common/adf_aer.c
> @@ -88,6 +88,9 @@ static void adf_dev_restore(struct adf_accel_dev *accel_dev)
>  	struct pci_dev *parent = pdev->bus->self;
>  	uint16_t bridge_ctl = 0;
>  
> +	if (accel_dev->is_vf)
> +		return;
> +
>  	dev_info(&GET_DEV(accel_dev), "Resetting device qat_dev%d\n",
>  		 accel_dev->accel_id);

This should also go to 4.2 stable.
Thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] crypto: qat - VF should never trigger SBR on PH
  2015-09-18 15:59 [PATCH] crypto: qat - VF should never trigger SBR on PH Tadeusz Struk
  2015-09-18 16:01 ` Tadeusz Struk
@ 2015-09-21 15:04 ` Herbert Xu
  2015-09-21 15:27   ` Tadeusz Struk
  1 sibling, 1 reply; 4+ messages in thread
From: Herbert Xu @ 2015-09-21 15:04 UTC (permalink / raw)
  To: Tadeusz Struk; +Cc: linux-crypto, qat-linux, conor.mcloughlin

On Fri, Sep 18, 2015 at 08:59:47AM -0700, Tadeusz Struk wrote:
> From: Conor McLoughlin <conor.mcloughlin@intel.com>
> 
> Don't allow to trigger SBR from a VF running in VMM context.
> 
> Signed-off-by: Conor McLoughlin <conor.mcloughlin@intel.com>
> Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>

Applied to crypto.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] crypto: qat - VF should never trigger SBR on PH
  2015-09-21 15:04 ` Herbert Xu
@ 2015-09-21 15:27   ` Tadeusz Struk
  0 siblings, 0 replies; 4+ messages in thread
From: Tadeusz Struk @ 2015-09-21 15:27 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-crypto, qat-linux, conor.mcloughlin

On 09/21/2015 08:04 AM, Herbert Xu wrote:
>> Don't allow to trigger SBR from a VF running in VMM context.
>> > 
>> > Signed-off-by: Conor McLoughlin <conor.mcloughlin@intel.com>
>> > Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
> Applied to crypto.

Thanks Herbert. Actually it's only needed for 4.3 when VF support was added.
Thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-09-21 15:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-18 15:59 [PATCH] crypto: qat - VF should never trigger SBR on PH Tadeusz Struk
2015-09-18 16:01 ` Tadeusz Struk
2015-09-21 15:04 ` Herbert Xu
2015-09-21 15:27   ` Tadeusz Struk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).